Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(forms): formGroupName and formArrayName also accepts a number #32607

Closed
wants to merge 1 commit into from
Closed

feat(forms): formGroupName and formArrayName also accepts a number #32607

wants to merge 1 commit into from

Conversation

Bil0
Copy link
Contributor

@Bil0 Bil0 commented Sep 11, 2019 •
edited by cexbrayat
Loading

For consistency, FormGroupName and FormaArrayName also accepts a
number as input's type like FormControlName

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #32436

Does this PR introduce a breaking change?

  • Yes
  • No

@Bil0 Bil0 requested review from a team as code owners September 11, 2019 11:48
@Bil0 Bil0 mentioned this pull request Sep 11, 2019
Closed
@cexbrayat
Copy link
Member

@Bil0 Thanks for the PR! I think most failures in CI are unrelated to your work and will be fixed if you rebase on latest master (the fix for the Docker images landed and should fix the failing e2e tests).
Ping me when you're done rebasing and I'll try to get a Googler to run a presubmit check (to verify this is not breaking any application inside Google) and to do a review.

@Bil0 Bil0 force-pushed the feat/form-group-array-name-as-number branch from 6adda44 to 0ea431c Compare September 11, 2019 21:07
@Bil0
Copy link
Contributor Author

Bil0 commented Sep 11, 2019

@cexbrayat, rebased & updated !

@Bil0
feat(forms): formGroupName and formArrayName also accepts a number
d9813a6 
For consistency, `FormGroupName` and `FormaArrayName` also accepts a
number as input's type like `FormControlName`

Closes angular#32436
@Bil0 Bil0 force-pushed the feat/form-group-array-name-as-number branch from 0ea431c to d9813a6 Compare September 11, 2019 21:46
@ngbot ngbot bot added this to the needsTriage milestone Sep 12, 2019
kara
kara approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added action: presubmit The PR is in need of a google3 presubmit target: major This PR is targeted for the next major release breaking changes labels Oct 3, 2019
@kara
Copy link
Contributor

kara commented Oct 3, 2019

presubmit

@kara kara removed the action: presubmit The PR is in need of a google3 presubmit label Oct 3, 2019
@kara kara added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Oct 4, 2019
@kara
Copy link
Contributor

kara commented Oct 4, 2019

caretaker note: we may want to do a global TAP for this

@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Oct 5, 2019 •
edited
Loading

Global VE Presubmit

@AndrewKushnir AndrewKushnir added the action: presubmit The PR is in need of a google3 presubmit label Oct 5, 2019
@AndrewKushnir
Copy link
Contributor

FYI, Global TAP presubmit is successful. Thank you.

@AndrewKushnir AndrewKushnir removed the action: presubmit The PR is in need of a google3 presubmit label Oct 6, 2019
@alxhub alxhub closed this in fee28e2 Oct 7, 2019
@cexbrayat
Copy link
Member

Thanks @Bil0 for taking the time to put this together 😉

ODAVING pushed a commit to ODAVING/angular that referenced this pull request Oct 18, 2019
@Bil0 @ODAVING
feat(forms): formGroupName and formArrayName also accepts a number (a…
e48de98 
…ngular#32607)

For consistency, `FormGroupName` and `FormaArrayName` also accepts a
number as input's type like `FormControlName`

Closes angular#32436

PR Close angular#32607
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cexbrayat cexbrayat cexbrayat approved these changes

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: forms breaking changes cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.
6 participants
@Bil0 @cexbrayat @kara @AndrewKushnir @matsko @googlebot