Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: copy edit getting started step 4 #32839

Closed
wants to merge 1 commit into from

Conversation

kapunahelewong
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Brings copy in line with Google guidelines. Also keeps location of getItems() consistent with previous step, Managing Data. In Managing Data, the cart service getItems() is in the ngOnInit(), but in the Forms step, it has moved to the constructor without instruction to do so.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kapunahelewong kapunahelewong requested a review from a team as a code owner September 24, 2019 19:32
@ngbot ngbot bot modified the milestone: Backlog Sep 24, 2019
@mary-poppins
Copy link

You can preview cb60d78 at https://pr32839-cb60d78.ngbuilds.io/.

Copy link
Contributor

@jbogarthyde jbogarthyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor edits

aio/content/start/forms.md Outdated Show resolved Hide resolved
aio/content/start/forms.md Outdated Show resolved Hide resolved
aio/content/start/forms.md Outdated Show resolved Hide resolved
@mary-poppins
Copy link

You can preview 96a6f96 at https://pr32839-96a6f96.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 9882a13 at https://pr32839-9882a13.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 55e7827 at https://pr32839-55e7827.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 6f3e5ae at https://pr32839-6f3e5ae.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 199589e at https://pr32839-199589e.ngbuilds.io/.

@gkalpak gkalpak added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Dec 14, 2019
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

aio/content/start/forms.md Outdated Show resolved Hide resolved
aio/content/start/forms.md Outdated Show resolved Hide resolved
@mary-poppins
Copy link

You can preview 351f118 at https://pr32839-351f118.ngbuilds.io/.

@kapunahelewong kapunahelewong removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Dec 18, 2019
@mary-poppins
Copy link

You can preview 5908a27 at https://pr32839-5908a27.ngbuilds.io/.

@kapunahelewong kapunahelewong added the action: merge The PR is ready for merge by the caretaker label Dec 18, 2019
@kara kara added the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 18, 2019
@kara
Copy link
Contributor

kara commented Dec 18, 2019

@IgorMinar @StephenFluin Can someone review this for fw-docs-intro group approval?

@kapunahelewong kapunahelewong removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 20, 2019
@alxhub alxhub closed this in 8410278 Jan 6, 2020
alxhub pushed a commit that referenced this pull request Jan 6, 2020
@kapunahelewong kapunahelewong deleted the gs-step4 branch January 6, 2020 21:07
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours risk: low target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants