-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: copy edit getting started step 4 #32839
Conversation
You can preview cb60d78 at https://pr32839-cb60d78.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor edits
cb60d78
to
96a6f96
Compare
You can preview 96a6f96 at https://pr32839-96a6f96.ngbuilds.io/. |
96a6f96
to
9882a13
Compare
You can preview 9882a13 at https://pr32839-9882a13.ngbuilds.io/. |
9882a13
to
55e7827
Compare
You can preview 55e7827 at https://pr32839-55e7827.ngbuilds.io/. |
55e7827
to
6f3e5ae
Compare
You can preview 6f3e5ae at https://pr32839-6f3e5ae.ngbuilds.io/. |
6f3e5ae
to
199589e
Compare
You can preview 199589e at https://pr32839-199589e.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
199589e
to
351f118
Compare
You can preview 351f118 at https://pr32839-351f118.ngbuilds.io/. |
351f118
to
7d5a193
Compare
7d5a193
to
5908a27
Compare
You can preview 5908a27 at https://pr32839-5908a27.ngbuilds.io/. |
@IgorMinar @StephenFluin Can someone review this for fw-docs-intro group approval? |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Brings copy in line with Google guidelines. Also keeps location of
getItems()
consistent with previous step, Managing Data. In Managing Data, the cart servicegetItems()
is in thengOnInit()
, but in the Forms step, it has moved to the constructor without instruction to do so.Does this PR introduce a breaking change?
Other information