Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs-infra): use .tooltip and highlight the currently active node in top-bar #33351

Closed
wants to merge 2 commits into from
Closed

fix(docs-infra): use .tooltip and highlight the currently active node in top-bar #33351

wants to merge 2 commits into from

Commits on Feb 20, 2020

  1. fix(docs-infra): use .tooltip in aio-top-menu items 

    The top-menu items have both a `title` and a `tooltip` property. The
`title` is used as text content, so there is little point in using it as
"tooltip" (via the HTMLElement's `title` property) too.

This commit switches to using the `tooltip` property to populate the
`title`. Note that in many cases, the `tooltip` property is derived from
`title` anyway (so there is no practical change in behavior in these
cases).
    @gkalpak
    gkalpak committed Feb 20, 2020
    Copy the full SHA
    79b7ddc View commit details
    Browse the repository at this point in the history

  2. fix(docs-infra): highlight the currently active node in top-bar 

    Related to angular#33239 and angular#33255.
    @gkalpak
    gkalpak committed Feb 20, 2020
    Copy the full SHA
    0ec3ce9 View commit details
    Browse the repository at this point in the history