fix(ivy): throw a better error when DI can't inject a ctor param #33739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxhub
force-pushed
the
di/missing-decorator-runtime
branch
4 times, most recently
from
3c6c287
to
6196365
Compare
kara
requested changes
Nov 11, 2019
| .toThrowError( | ||
| /constructor is not compatible with Angular Dependency Injection because its dependency for its parameter 2 is invalid/); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Can we add a test for the missing directive decorator case?
kara
added
area: compiler
alxhub
force-pushed
the
di/missing-decorator-runtime
branch
from
6196365
to
d7f2cda
Compare
kara
reviewed
Nov 18, 2019
alxhub
force-pushed
the
di/missing-decorator-runtime
branch
from
d7f2cda
to
2f8a0ec
Compare
alxhub
added
action: merge
kara
added
the
merge: caretaker note
|
merge-assistance: global approval |
|
Needs rebase and fails g3 |
AndrewKushnir
added
state: blocked
and removed
action: merge
AndrewKushnir
removed
the
action: presubmit
Occasionally a factory function needs to be generated for an "invalid" constructor (one with parameters types which aren't injectable). Typically this happens in JIT mode where understanding of parameters cannot be done in the same "up-front" way that the AOT compiler can. This commit changes the JIT compiler to generate a new `invalidFactoryDep` call for each invalid parameter. This instruction will error at runtime if called, indicating both the index of the invalid parameter as well as (via the stack trace) the factory function which was generated for the type being constructed. Fixes angular#33637
alxhub
force-pushed
the
di/missing-decorator-runtime
branch
from
2f8a0ec
to
e09bc43
Compare
alxhub
added
action: merge
AndrewKushnir
pushed a commit
to AndrewKushnir/angular
that referenced
this pull request
Dec 11, 2019
…ular#33739) Occasionally a factory function needs to be generated for an "invalid" constructor (one with parameters types which aren't injectable). Typically this happens in JIT mode where understanding of parameters cannot be done in the same "up-front" way that the AOT compiler can. This commit changes the JIT compiler to generate a new `invalidFactoryDep` call for each invalid parameter. This instruction will error at runtime if called, indicating both the index of the invalid parameter as well as (via the stack trace) the factory function which was generated for the type being constructed. Fixes angular#33637 PR Close angular#33739
AndrewKushnir
pushed a commit
that referenced
this pull request
Dec 11, 2019
) (#34340) Occasionally a factory function needs to be generated for an "invalid" constructor (one with parameters types which aren't injectable). Typically this happens in JIT mode where understanding of parameters cannot be done in the same "up-front" way that the AOT compiler can. This commit changes the JIT compiler to generate a new `invalidFactoryDep` call for each invalid parameter. This instruction will error at runtime if called, indicating both the index of the invalid parameter as well as (via the stack trace) the factory function which was generated for the type being constructed. Fixes #33637 PR Close #33739 PR Close #34340
josephperrott
pushed a commit
to josephperrott/angular
that referenced
this pull request
Dec 11, 2019
…ular#33739) Occasionally a factory function needs to be generated for an "invalid" constructor (one with parameters types which aren't injectable). Typically this happens in JIT mode where understanding of parameters cannot be done in the same "up-front" way that the AOT compiler can. This commit changes the JIT compiler to generate a new `invalidFactoryDep` call for each invalid parameter. This instruction will error at runtime if called, indicating both the index of the invalid parameter as well as (via the stack trace) the factory function which was generated for the type being constructed. Fixes angular#33637 PR Close angular#33739
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally a factory function needs to be generated for an "invalid"
constructor (one with parameters types which aren't injectable). Typically
this happens in JIT mode where understanding of parameters cannot be done in
the same "up-front" way that the AOT compiler can.
This commit changes the JIT compiler to generate a new
invalidFactoryDepcall for each invalid parameter. This instruction will error at runtime if
called, indicating both the index of the invalid parameter as well as (via
the stack trace) the factory function which was generated for the type being
constructed.