Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules nodejs 1.0.1 #34589

Closed
wants to merge 18 commits into from
Closed

Commits on Jan 10, 2020

  1. build: upgrade to rules_nodejs 1.0.0 (first stable release)

    Brings in the fix for stamping which was preventing many targets from getting cached.
    gregmagolan committed Jan 10, 2020
    Copy the full SHA
    a7b88bd View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    b7c6dc1 View commit details
    Browse the repository at this point in the history
  3. refactor: handle breaking changes in rules_nodejs 1.0.0

    The major one that affects the angular repo is the removal of the bootstrap attribute in nodejs_binary, nodejs_test and jasmine_node_test in favor of using templated_args --node_options=--require=/path/to/script. The side-effect of this is that the bootstrap script does not get the require.resolve patches with explicitly loading the targets _loader.js file.
    gregmagolan committed Jan 10, 2020
    Copy the full SHA
    bce853c View commit details
    Browse the repository at this point in the history
  4. build: package-build & release scripts should handle new pkg_npm naming

    bazel query now using: kind("ng_package|pkg_npm", //packages/...)
    gregmagolan committed Jan 10, 2020
    Copy the full SHA
    b1c8c44 View commit details
    Browse the repository at this point in the history
  5. build: update integration/bazel & @angular/bazel schematics to rules_…

    …nodejs 1.0.0
    
    For the purposes of the integration test the zone.js script & bundle script tags can just go into the source index.html itself. The purpose of the integration test is is to test @angular/bazel & ng_module & ng_package so there is no need to exercise html_insert_assets in integration/bazel.
    gregmagolan committed Jan 10, 2020
    Copy the full SHA
    dd774e5 View commit details
    Browse the repository at this point in the history
  6. build: update to @angular/cli 9.0.0-rc.4

    This brings in a required fix to allow for 0.0.0 dev version of @angular/core for integration testing. Without this the following error is now observed:
    
    ```
    This version of CLI is only compatible with Angular versions ^9.0.0-beta || >=9.0.0 <10.0.0,
    but Angular version 0.0.0 was found instead.
    ```
    
    NB: rc.7 breaks the cli-hello-world-ivy-i18n integration test
    gregmagolan committed Jan 10, 2020
    Copy the full SHA
    72fd58a View commit details
    Browse the repository at this point in the history
  7. build: update to rules nodejs 1.0.1

    This brings in a few minor fixes including a better way to patch require for bootstrap scripts.
    gregmagolan committed Jan 10, 2020
    Copy the full SHA
    1e7209c View commit details
    Browse the repository at this point in the history
  8. test: update to latest angular/components commit to pick up rules_nod…

    …ejs 1.0 update
    
    This commit includes angular/components#18064 which is a pre-req for updating the angular repo to rules_nodejs 1.0.
    gregmagolan committed Jan 10, 2020
    Copy the full SHA
    f1ac79b View commit details
    Browse the repository at this point in the history
  9. test: bump material cache_key version

    Also add comment that cache_key version should be bumped when switching forks or branches and added a comment from @devversion explaining how the fallback cache key works.
    gregmagolan committed Jan 10, 2020
    Copy the full SHA
    9b62fe1 View commit details
    Browse the repository at this point in the history
  10. Copy the full SHA
    2e4385f View commit details
    Browse the repository at this point in the history
  11. Copy the full SHA
    fbd4fcc View commit details
    Browse the repository at this point in the history
  12. Copy the full SHA
    88c968b View commit details
    Browse the repository at this point in the history
  13. build: add a before-all-other bootstrap script that patches require

    This removes the churn in the existing bootstrap scripts.
    gregmagolan committed Jan 10, 2020
    Copy the full SHA
    5fa1768 View commit details
    Browse the repository at this point in the history
  14. build: should use $(execpath) in npm_package_bin args

    This is recommended in the Bazel docs as $(location) is ambiguous and can mean either $(execpath) or $(rootpath) depending on the context.
    gregmagolan committed Jan 10, 2020
    Copy the full SHA
    c54c6cc View commit details
    Browse the repository at this point in the history
  15. Copy the full SHA
    251482c View commit details
    Browse the repository at this point in the history
  16. Copy the full SHA
    5c6ff25 View commit details
    Browse the repository at this point in the history
  17. Copy the full SHA
    2b3c57a View commit details
    Browse the repository at this point in the history
  18. Copy the full SHA
    0788bf0 View commit details
    Browse the repository at this point in the history