Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Rules nodejs 1.0.1 #34589
Update to first stable release of rules_nodejs.
Breaking changes in rules_nodejs will be more controlled in the future.
This PR also updates integration/bazel and @angular/bazel schematics to rules_nodejs 1.0.0
For the purposes of the integration test the zone.js script & bundle script tags can just go into the source index.html itself. The purpose of the integration test is is to test @angular/bazel & ng_module & ng_package so there is no need to exercise html_insert_assets in integration/bazel.
Please check if your PR fulfills the following requirements:
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
I'd recommend all angular developers turn on disk_cache in their
With that on, flipping between
material-unit-tests CI job waiting on angular/components#18064 to land.
Temporarily updated to my angular/components rules_nodejs 1.0.0 commit for https://github.com/angular/components/pull/18064to green up CI and will update to upstream commit once angular/components#18064 lands.
@gregmagolan Just to confirm, what you show here confirms that the results of the test targets being build is stable and leads to us having full cache hits for
Did you confirm that we also are seeing (as fully as possible), remote cache hits for the
This is what I want to start looking into showing in our logs with something like #34439, so we can see how many of the individual spawned actions can be cache hits.
Remote-cache is being hit for most actions. I don't have the number to compare from before this update yet but running those benchmarks now.
On a clean build with --disk_cash enabled and pre-populated I got,
On clean build with --config=remote (OSX cross-platform) enabled and pre-populated and with no --disk_cache,
@josephperrott @IgorMinar Just a heads up that I initially updated to @angular/cli rc.7 but that breaks the cli-hello-world-ivy-i18n integration test. Other integration tests still pass so something particular about that one.
This PR now just updated to @angular/cli rc.4 to pick up the "0.0.0" @angular/core version fix otherwise the following is observed.
Somewhere between @angular/cli rc.5 & rc.7 the
Same benchmark on current
Clean build with --disk_cash enabled and pre-populated:
On clean build with --config=remote (OSX cross-platform) enabled and pre-populated and with no --disk_cache: