Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules nodejs 1.0.1 #34589

Closed
wants to merge 18 commits into from
Closed

Conversation

@gregmagolan
Copy link
Contributor

gregmagolan commented Dec 29, 2019

Update to first stable release of rules_nodejs.

  • Folds in rules_nodejs breaking changes that were made for 1.0 after BazelCoreWeb API review. The major one that affects the angular repo is the removal of the bootstrap attribute in nodejs_binary, nodejs_test and jasmine_node_test in favor of using templated_args --node_options=--require=/path/to/script. The side-effect of this is that the bootstrap script does not get the require.resolve patches with explicitly loading the targets _loader.js file.

  • Brings in the fix for stamping which was preventing many targets from getting cached.

Breaking changes in rules_nodejs will be more controlled in the future.

This PR also updates integration/bazel and @angular/bazel schematics to rules_nodejs 1.0.0

For the purposes of the integration test the zone.js script & bundle script tags can just go into the source index.html itself. The purpose of the integration test is is to test @angular/bazel & ng_module & ng_package so there is no need to exercise html_insert_assets in integration/bazel.


PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@googlebot googlebot added the cla: yes label Dec 29, 2019
@gregmagolan gregmagolan force-pushed the gregmagolan:rules_nodejs_1.0.0 branch 2 times, most recently from 4bfd91c to 928c969 Dec 29, 2019
@gregmagolan

This comment has been minimized.

Copy link
Contributor Author

gregmagolan commented Dec 29, 2019

@josephperrott @IgorMinar bazel test ... is now fully cached with this update.

$ yarn test-non-ivy ...

INFO: Build completed successfully, 1 total action
//modules/benchmarks/src/class_bindings:perf_chromium           (cached) PASSED in 3.0s
//modules/benchmarks/src/expanding_rows:perf_chromium           (cached) PASSED in 54.0s
//modules/benchmarks/src/js-web-frameworks/ng2:perf_chromium    (cached) PASSED in 3.9s
//modules/benchmarks/src/largeform/ng2:perf_chromium            (cached) PASSED in 2.7s
//modules/benchmarks/src/largetable/baseline:perf_chromium      (cached) PASSED in 3.0s
//modules/benchmarks/src/largetable/incremental_dom:perf_chromium (cached) PASSED in 2.9s
//modules/benchmarks/src/largetable/iv:perf_chromium            (cached) PASSED in 3.4s
//modules/benchmarks/src/largetable/ng2:perf_chromium           (cached) PASSED in 2.6s
//modules/benchmarks/src/largetable/ng2_switch:perf_chromium    (cached) PASSED in 2.8s
//modules/benchmarks/src/tree/baseline:perf_chromium            (cached) PASSED in 4.5s
//modules/benchmarks/src/tree/incremental_dom:perf_chromium     (cached) PASSED in 3.8s
//modules/benchmarks/src/tree/iv:perf_chromium                  (cached) PASSED in 3.8s
//modules/benchmarks/src/tree/ng1:perf_chromium                 (cached) PASSED in 3.8s
//modules/benchmarks/src/tree/ng2:perf_chromium                 (cached) PASSED in 2.5s
//modules/benchmarks/src/tree/ng2_next:perf_chromium            (cached) PASSED in 3.7s
//modules/benchmarks/src/tree/ng2_static:perf_chromium          (cached) PASSED in 3.8s
//modules/benchmarks/src/tree/ng2_switch:perf_chromium          (cached) PASSED in 2.6s
//modules/benchmarks/src/tree/render3_function:perf_chromium    (cached) PASSED in 5.4s
//modules/playground/e2e_test/async:protractor_tests_chromium   (cached) PASSED in 3.6s
//modules/playground/e2e_test/hello_world:protractor_tests_chromium (cached) PASSED in 2.9s
//modules/playground/e2e_test/http:protractor_tests_chromium    (cached) PASSED in 3.9s
//modules/playground/e2e_test/jsonp:protractor_tests_chromium   (cached) PASSED in 3.3s
//modules/playground/e2e_test/key_events:protractor_tests_chromium (cached) PASSED in 2.5s
//modules/playground/e2e_test/model_driven_forms:protractor_tests_chromium (cached) PASSED in 3.5s
//modules/playground/e2e_test/order_management:protractor_tests_chromium (cached) PASSED in 3.5s
//modules/playground/e2e_test/person_management:protractor_tests_chromium (cached) PASSED in 2.3s
//modules/playground/e2e_test/relative_assets:protractor_tests_chromium (cached) PASSED in 2.3s
//modules/playground/e2e_test/routing:protractor_tests_chromium (cached) PASSED in 2.8s
//modules/playground/e2e_test/sourcemap:protractor_tests_chromium (cached) PASSED in 3.0s
//modules/playground/e2e_test/svg:protractor_tests_chromium     (cached) PASSED in 2.2s
//modules/playground/e2e_test/template_driven_forms:protractor_tests_chromium (cached) PASSED in 2.7s
//modules/playground/e2e_test/upgrade:protractor_tests_chromium (cached) PASSED in 3.2s
//modules/playground/e2e_test/web_workers/animations:protractor_tests_chromium (cached) PASSED in 3.2s
//modules/playground/e2e_test/web_workers/input:protractor_tests_chromium (cached) PASSED in 3.1s
//modules/playground/e2e_test/web_workers/kitchen_sink:protractor_tests_chromium (cached) PASSED in 3.4s
//modules/playground/e2e_test/web_workers/message_broker:protractor_tests_chromium (cached) PASSED in 2.6s
//modules/playground/e2e_test/web_workers/router:protractor_tests_chromium (cached) PASSED in 3.2s
//modules/playground/e2e_test/web_workers/todo:protractor_tests_chromium (cached) PASSED in 2.8s
//modules/playground/e2e_test/zippy_component:protractor_tests_chromium (cached) PASSED in 2.4s
//packages/animations/browser/test:test                         (cached) PASSED in 0.1s
//packages/animations/browser/test:test_web_chromium            (cached) PASSED in 2.0s
//packages/animations/test:test                                 (cached) PASSED in 0.1s
//packages/animations/test:test_web_chromium                    (cached) PASSED in 3.0s
//packages/bazel/src/schematics:test                            (cached) PASSED in 0.1s
//packages/bazel/test/ng_package:common_package                 (cached) PASSED in 0.1s
//packages/bazel/test/ng_package:core_package                   (cached) PASSED in 0.1s
//packages/bazel/test/ng_package:example_package                (cached) PASSED in 0.9s
//packages/bazel/test/ngc-wrapped:flat_module_test              (cached) PASSED in 0.1s
//packages/bazel/test/ngc-wrapped:ngc_test                      (cached) PASSED in 0.1s
//packages/benchpress/test:test                                 (cached) PASSED in 0.1s
//packages/common/http/test:test                                (cached) PASSED in 0.1s
//packages/common/http/test:test_web_chromium                   (cached) PASSED in 4.4s
//packages/common/http/testing/test:test                        (cached) PASSED in 0.1s
//packages/common/http/testing/test:test_web_chromium           (cached) PASSED in 4.8s
//packages/common/test:test                                     (cached) PASSED in 0.1s
//packages/common/test:test_web_chromium                        (cached) PASSED in 4.0s
//packages/common/upgrade/test:test                             (cached) PASSED in 0.1s
//packages/compiler-cli/integrationtest:integrationtest         (cached) PASSED in 115.6s
//packages/compiler-cli/integrationtest/bazel/injectable_def/app/test:test (cached) PASSED in 0.1s
//packages/compiler-cli/integrationtest/bazel/ng_module:test    (cached) PASSED in 0.6s
//packages/compiler-cli/ngcc/test:integration                   (cached) PASSED in 280.8s
  Stats over 4 runs: max = 280.8s, min = 275.1s, avg = 277.9s, dev = 2.7s
//packages/compiler-cli/ngcc/test:test                          (cached) PASSED in 0.0s
//packages/compiler-cli/src/ngtsc/annotations/test:test         (cached) PASSED in 0.0s
//packages/compiler-cli/src/ngtsc/cycles/test:test              (cached) PASSED in 0.0s
//packages/compiler-cli/src/ngtsc/entry_point/test:test         (cached) PASSED in 0.0s
//packages/compiler-cli/src/ngtsc/file_system/test:test         (cached) PASSED in 0.0s
//packages/compiler-cli/src/ngtsc/imports/test:test             (cached) PASSED in 0.0s
//packages/compiler-cli/src/ngtsc/indexer/test:test             (cached) PASSED in 0.0s
//packages/compiler-cli/src/ngtsc/partial_evaluator/test:test   (cached) PASSED in 0.0s
//packages/compiler-cli/src/ngtsc/reflection/test:test          (cached) PASSED in 0.0s
//packages/compiler-cli/src/ngtsc/scope/test:test               (cached) PASSED in 0.0s
//packages/compiler-cli/src/ngtsc/shims/test:test               (cached) PASSED in 0.0s
//packages/compiler-cli/src/ngtsc/typecheck/test:test           (cached) PASSED in 0.0s
//packages/compiler-cli/src/ngtsc/util/test:test                (cached) PASSED in 0.0s
//packages/compiler-cli/test:extract_i18n                       (cached) PASSED in 3.6s
//packages/compiler-cli/test:ngc                                (cached) PASSED in 2.0s
//packages/compiler-cli/test:perform_compile                    (cached) PASSED in 0.1s
//packages/compiler-cli/test:perform_watch                      (cached) PASSED in 0.1s
//packages/compiler-cli/test/diagnostics:check_types            (cached) PASSED in 3.5s
//packages/compiler-cli/test/diagnostics:typescript_version     (cached) PASSED in 0.3s
//packages/compiler-cli/test/metadata:test                      (cached) PASSED in 0.1s
//packages/compiler-cli/test/ngtsc:ngtsc                        (cached) PASSED in 0.0s
  Stats over 4 runs: max = 0.0s, min = 0.0s, avg = 0.0s, dev = 0.0s
//packages/compiler-cli/test/transformers:test                  (cached) PASSED in 3.9s
//packages/compiler/test:test                                   (cached) PASSED in 3.6s
//packages/compiler/test:test_web_chromium                      (cached) PASSED in 29.2s
//packages/compiler/test/css_parser:css_parser                  (cached) PASSED in 0.1s
//packages/compiler/test/css_parser:css_parser_web_chromium     (cached) PASSED in 3.6s
//packages/compiler/test/expression_parser:expression_parser    (cached) PASSED in 0.1s
//packages/compiler/test/expression_parser:expression_parser_web_chromium (cached) PASSED in 2.1s
//packages/compiler/test/ml_parser:ml_parser                    (cached) PASSED in 0.1s
//packages/compiler/test/ml_parser:ml_parser_web_chromium       (cached) PASSED in 4.1s
//packages/compiler/test/render3:test                           (cached) PASSED in 0.1s
//packages/compiler/test/selector:selector                      (cached) PASSED in 0.1s
//packages/compiler/test/selector:selector_web_chromium         (cached) PASSED in 3.0s
//packages/core/schematics/test:test                            (cached) PASSED in 0.1s
//packages/core/schematics/test/google3:google3                 (cached) PASSED in 0.1s
//packages/core/test:test                                       (cached) PASSED in 0.1s
  Stats over 4 runs: max = 0.1s, min = 0.1s, avg = 0.1s, dev = 0.0s
//packages/core/test:test_web_chromium                          (cached) PASSED in 3.4s
//packages/core/test/acceptance:acceptance                      (cached) PASSED in 0.1s
//packages/core/test/acceptance:acceptance_web_chromium         (cached) PASSED in 4.3s
//packages/core/test/render3:render3                            (cached) PASSED in 4.8s
//packages/core/test/render3:render3_web_chromium               (cached) PASSED in 4.0s
//packages/core/test/render3/perf:perf                          (cached) PASSED in 0.1s
//packages/core/test/strict_types:strict_types                  (cached) PASSED in 0.1s
//packages/core/test/view:view                                  (cached) PASSED in 3.3s
//packages/core/test/view:view_web_chromium                     (cached) PASSED in 14.4s
//packages/elements/schematics/ng-add:test                      (cached) PASSED in 0.0s
//packages/elements/test:test_chromium                          (cached) PASSED in 4.2s
//packages/examples/common:protractor_tests_chromium            (cached) PASSED in 3.2s
//packages/examples/core:protractor_tests_chromium              (cached) PASSED in 2.2s
//packages/examples/core:test                                   (cached) PASSED in 0.1s
//packages/examples/core/testing/ts:test                        (cached) PASSED in 0.1s
//packages/examples/forms:protractor_tests_chromium             (cached) PASSED in 2.9s
//packages/examples/service-worker/push:protractor_tests_chromium (cached) PASSED in 5.4s
//packages/examples/service-worker/registration-options:protractor_tests_chromium (cached) PASSED in 4.0s
//packages/examples/upgrade/static/ts/full:full_protractor_chromium (cached) PASSED in 3.1s
//packages/examples/upgrade/static/ts/lite:lite_protractor_chromium (cached) PASSED in 4.0s
//packages/examples/upgrade/static/ts/lite-multi:lite-multi_protractor_chromium (cached) PASSED in 2.3s
//packages/examples/upgrade/static/ts/lite-multi-shared:lite-multi-shared_protractor_chromium (cached) PASSED in 2.5s
//packages/forms/test:test                                      (cached) PASSED in 0.1s
//packages/forms/test:test_web_chromium                         (cached) PASSED in 3.0s
//packages/http/test:test                                       (cached) PASSED in 0.1s
//packages/http/test:test_web_chromium                          (cached) PASSED in 2.9s
//packages/language-service/test:diagnostics                    (cached) PASSED in 15.0s
//packages/language-service/test:test                           (cached) PASSED in 68.8s
//packages/localize/schematics/ng-add:test                      (cached) PASSED in 0.1s
//packages/localize/src/localize/test:test                      (cached) PASSED in 0.0s
//packages/localize/src/tools/test:test                         (cached) PASSED in 0.0s
//packages/localize/src/tools/test/translate/integration:integration (cached) PASSED in 0.1s
//packages/localize/src/utils/test:test                         (cached) PASSED in 0.0s
//packages/localize/test:test                                   (cached) PASSED in 0.0s
//packages/platform-browser-dynamic/test:test                   (cached) PASSED in 0.1s
//packages/platform-browser-dynamic/test:test_web_chromium      (cached) PASSED in 4.9s
//packages/platform-browser/animations/test:test                (cached) PASSED in 0.1s
//packages/platform-browser/animations/test:test_web_chromium   (cached) PASSED in 3.3s
//packages/platform-browser/test:test                           (cached) PASSED in 0.1s
//packages/platform-browser/test:test_web_chromium              (cached) PASSED in 3.1s
//packages/platform-server/test:test                            (cached) PASSED in 0.1s
//packages/platform-webworker/test:test                         (cached) PASSED in 0.1s
//packages/platform-webworker/test:test_web_chromium            (cached) PASSED in 3.2s
//packages/router/test:test                                     (cached) PASSED in 0.1s
//packages/router/test:test_web_chromium                        (cached) PASSED in 3.2s
//packages/router/test/aot_ngsummary_test:test                  (cached) PASSED in 0.1s
//packages/router/upgrade/test:test_web_chromium                (cached) PASSED in 2.7s
//packages/service-worker/config/test:test                      (cached) PASSED in 0.1s
//packages/service-worker/test:test                             (cached) PASSED in 0.1s
//packages/service-worker/test:test_web_chromium                (cached) PASSED in 2.4s
//packages/service-worker/worker/test:test                      (cached) PASSED in 0.1s
//packages/upgrade/src/common/test:test_chromium                (cached) PASSED in 4.1s
//packages/upgrade/src/dynamic/test:test_chromium               (cached) PASSED in 4.4s
//packages/upgrade/static/test:test_chromium                    (cached) PASSED in 2.5s
//packages/upgrade/static/testing/test:test_chromium            (cached) PASSED in 5.3s
//packages/zone.js/test:browser_green_test_karma_jasmine_test_chromium (cached) PASSED in 13.9s
//packages/zone.js/test:browser_legacy_test_karma_jasmine_test_chromium (cached) PASSED in 14.3s
//packages/zone.js/test:browser_shadydom_karma_jasmine_test_chromium (cached) PASSED in 8.2s
//packages/zone.js/test:browser_test_karma_jasmine_test_chromium (cached) PASSED in 12.5s
//packages/zone.js/test:karma_jasmine_test_ci_chromium          (cached) PASSED in 7.3s
//packages/zone.js/test:test_node                               (cached) PASSED in 0.1s
//packages/zone.js/test:test_node_bluebird                      (cached) PASSED in 0.0s
//packages/zone.js/test:test_node_error_disable_policy          (cached) PASSED in 0.0s
//packages/zone.js/test:test_node_error_lazy_policy             (cached) PASSED in 0.1s
//packages/zone.js/test:test_node_no_jasmine_clock              (cached) PASSED in 0.1s
//packages/zone.js/test:test_npm_package                        (cached) PASSED in 0.1s
//tools/public_api_guard:animations_api                         (cached) PASSED in 0.0s
//tools/public_api_guard:animations_browser_api                 (cached) PASSED in 2.9s
//tools/public_api_guard:animations_browser_testing_api         (cached) PASSED in 3.6s
//tools/public_api_guard:common_api                             (cached) PASSED in 4.2s
//tools/public_api_guard:common_http_api                        (cached) PASSED in 5.0s
//tools/public_api_guard:common_http_testing_api                (cached) PASSED in 3.2s
//tools/public_api_guard:common_testing_api                     (cached) PASSED in 2.3s
//tools/public_api_guard:common_upgrade_api                     (cached) PASSED in 4.5s
//tools/public_api_guard:core_api                               (cached) PASSED in 4.1s
//tools/public_api_guard:core_testing_api                       (cached) PASSED in 3.0s
//tools/public_api_guard:elements_api                           (cached) PASSED in 3.7s
//tools/public_api_guard:forms_api                              (cached) PASSED in 5.3s
//tools/public_api_guard:http_api                               (cached) PASSED in 4.2s
//tools/public_api_guard:http_testing_api                       (cached) PASSED in 2.8s
//tools/public_api_guard:localize_api                           (cached) PASSED in 3.0s
//tools/public_api_guard:ng_global_utils_api                    (cached) PASSED in 0.0s
//tools/public_api_guard:platform-browser-dynamic_api           (cached) PASSED in 2.6s
//tools/public_api_guard:platform-browser-dynamic_testing_api   (cached) PASSED in 4.4s
//tools/public_api_guard:platform-browser_animations_api        (cached) PASSED in 3.2s
//tools/public_api_guard:platform-browser_api                   (cached) PASSED in 3.4s
//tools/public_api_guard:platform-browser_testing_api           (cached) PASSED in 3.1s
//tools/public_api_guard:platform-server_api                    (cached) PASSED in 2.8s
//tools/public_api_guard:platform-server_testing_api            (cached) PASSED in 3.2s
//tools/public_api_guard:platform-webworker-dynamic_api         (cached) PASSED in 2.5s
//tools/public_api_guard:platform-webworker_api                 (cached) PASSED in 3.6s
//tools/public_api_guard:router_api                             (cached) PASSED in 4.1s
//tools/public_api_guard:router_testing_api                     (cached) PASSED in 4.2s
//tools/public_api_guard:router_upgrade_api                     (cached) PASSED in 3.6s
//tools/public_api_guard:service-worker_api                     (cached) PASSED in 3.0s
//tools/public_api_guard:service-worker_config_api              (cached) PASSED in 3.8s
//tools/public_api_guard:upgrade_api                            (cached) PASSED in 3.0s
//tools/public_api_guard:upgrade_static_api                     (cached) PASSED in 4.6s
//tools/public_api_guard:upgrade_static_testing_api             (cached) PASSED in 2.5s
//tools/size-tracking:test                                      (cached) PASSED in 0.1s
//tools/symbol-extractor:test                                   (cached) PASSED in 0.0s
//tools/ts-api-guardian:tests                                   (cached) PASSED in 47.3s
//tools/validate-commit-message:validate-commit-message         (cached) PASSED in 0.0s

I'd recommend all angular developers turn on disk_cache in their ~/.bazelrc file:

build --disk_cache=~/.cache/bazel-disk-cache

With that on, flipping between yarn test-non-ivy ... and yarn test-ivy-aot ... is cached even if remote-cache is not in use.

@gregmagolan gregmagolan force-pushed the gregmagolan:rules_nodejs_1.0.0 branch 2 times, most recently from 61d63ec to a7a2c7f Dec 29, 2019
gregmagolan added a commit to gregmagolan/components that referenced this pull request Dec 29, 2019
Dependency sandwich exists between material & angular so we need to patch both @angular/bazel & ts-api-guardian npm packages to land this so that the material-unit-test CI job in angular/angular#34589 can be greened up.
@gregmagolan

This comment has been minimized.

Copy link
Contributor Author

gregmagolan commented Dec 29, 2019

material-unit-tests CI job waiting on angular/components#18064 to land.

Temporarily updated to my angular/components rules_nodejs 1.0.0 commit for https://github.com/angular/components/pull/18064to green up CI and will update to upstream commit once angular/components#18064 lands.

@josephperrott

This comment has been minimized.

Copy link
Member

josephperrott commented Dec 29, 2019

@gregmagolan Just to confirm, what you show here confirms that the results of the test targets being build is stable and leads to us having full cache hits for test action executions.

Did you confirm that we also are seeing (as fully as possible), remote cache hits for the build actions themselves? I believe we were already seeing everything return as cache hits for our test executions, but we determined that we were having to redo alot of work in the build process to get there still.

This is what I want to start looking into showing in our logs with something like #34439, so we can see how many of the individual spawned actions can be cache hits.

gregmagolan added a commit to gregmagolan/components that referenced this pull request Dec 29, 2019
Dependency sandwich exists between material & angular so we need to patch both @angular/bazel & ts-api-guardian npm packages to land this so that the material-unit-test CI job in angular/angular#34589 can be greened up.
@ngbot ngbot bot added this to the needsTriage milestone Dec 29, 2019
gregmagolan added a commit to gregmagolan/components that referenced this pull request Dec 29, 2019
Dependency sandwich exists between material & angular so we need to patch both @angular/bazel & ts-api-guardian npm packages to land this so that the material-unit-test CI job in angular/angular#34589 can be greened up.
@gregmagolan gregmagolan force-pushed the gregmagolan:rules_nodejs_1.0.0 branch 2 times, most recently from 8abea47 to d927122 Dec 29, 2019
gregmagolan added a commit to gregmagolan/components that referenced this pull request Dec 29, 2019
Dependency sandwich exists between material & angular so we need to patch both @angular/bazel & ts-api-guardian npm packages to land this so that the material-unit-test CI job in angular/angular#34589 can be greened up.
@gregmagolan gregmagolan force-pushed the gregmagolan:rules_nodejs_1.0.0 branch from b91df22 to f255213 Dec 30, 2019
@gregmagolan

This comment has been minimized.

Copy link
Contributor Author

gregmagolan commented Dec 30, 2019

Remote-cache is being hit for most actions. I don't have the number to compare from before this update yet but running those benchmarks now.

On a clean build with --disk_cash enabled and pre-populated I got,

$ yarn test-non-ivy ... --disk_cache=~/.cache/bazel-disk-cache

INFO: Elapsed time: 320.595s, Critical Path: 101.72s
INFO: 2620 processes: 2425 remote cache hit, 195 darwin-sandbox.
INFO: Build completed successfully, 44363 total actions

All tests cached & PASSED

Executed 0 out of 200 tests: 200 tests pass.
INFO: Build completed successfully, 44363 total actions

On clean build with --config=remote (OSX cross-platform) enabled and pre-populated and with no --disk_cache,

$ yarn test-non-ivy ... --config=remote --google_credentials=/Users/greg/gcp_rbe.json --cpu=k8 --host_cpu=k8

INFO: Elapsed time: 781.324s, Critical Path: 757.82s
INFO: 2617 processes: 2422 remote cache hit, 195 remote.
INFO: Build completed successfully, 44361 total actions

All tests cached & PASSED

Executed 0 out of 200 tests: 200 tests pass.
INFO: Build completed successfully, 44361 total actions
@gregmagolan

This comment has been minimized.

Copy link
Contributor Author

gregmagolan commented Dec 30, 2019

@josephperrott @IgorMinar Just a heads up that I initially updated to @angular/cli rc.7 but that breaks the cli-hello-world-ivy-i18n integration test. Other integration tests still pass so something particular about that one.

This PR now just updated to @angular/cli rc.4 to pick up the "0.0.0" @angular/core version fix otherwise the following is observed.

This version of CLI is only compatible with Angular versions ^9.0.0-beta || >=9.0.0 <10.0.0,
but Angular version 0.0.0 was found instead.

Somewhere between @angular/cli rc.5 & rc.7 the cli-hello-world-ivy-i18n integration test breaks.

@gregmagolan

This comment has been minimized.

Copy link
Contributor Author

gregmagolan commented Dec 30, 2019

Same benchmark on current master has fewer remote cache hits and a number of actions that are forced local.

Clean build with --disk_cash enabled and pre-populated:

INFO: Elapsed time: 296.378s, Critical Path: 85.78s
INFO: 2407 processes: 2102 remote cache hit, 274 darwin-sandbox, 31 local.
INFO: Build completed successfully, 43512 total actions

All tests cached & PASSED

Executed 0 out of 200 tests: 200 tests pass.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.
INFO: Build completed successfully, 43512 total actions

On clean build with --config=remote (OSX cross-platform) enabled and pre-populated and with no --disk_cache:

INFO: Elapsed time: 733.490s, Critical Path: 698.26s
INFO: 2404 processes: 2100 remote cache hit, 31 local, 273 remote.
INFO: Build completed successfully, 43510 total actions

All tests cached & PASSED

Executed 0 out of 200 tests: 200 tests pass.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.
INFO: Build completed successfully, 43510 total actions
gregmagolan added a commit to gregmagolan/components that referenced this pull request Dec 31, 2019
Dependency sandwich exists between material & angular so we need to patch both @angular/bazel & ts-api-guardian npm packages to land this so that the material-unit-test CI job in angular/angular#34589 can be greened up.
gregmagolan added a commit to gregmagolan/components that referenced this pull request Dec 31, 2019
Dependency sandwich exists between material & angular so we need to patch both @angular/bazel & ts-api-guardian npm packages to land this so that the material-unit-test CI job in angular/angular#34589 can be greened up.
gregmagolan added a commit to gregmagolan/components that referenced this pull request Dec 31, 2019
Dependency sandwich exists between material & angular so we need to patch both @angular/bazel & ts-api-guardian npm packages to land this so that the material-unit-test CI job in angular/angular#34589 can be greened up.
@gregmagolan gregmagolan force-pushed the gregmagolan:rules_nodejs_1.0.0 branch 2 times, most recently from 743f3e5 to fde9c07 Jan 3, 2020
atscott added a commit that referenced this pull request Jan 10, 2020
…ng additional_root_paths (#34589)" (#34730)

This reverts commit 3fda893.

PR Close #34730
atscott added a commit that referenced this pull request Jan 10, 2020
…faults.bzl (#34589)" (#34730)

This reverts commit da4782e.

PR Close #34730
atscott added a commit that referenced this pull request Jan 10, 2020
This reverts commit 0e52d92.

PR Close #34730
atscott added a commit that referenced this pull request Jan 10, 2020
…ules_nodejs 1.0 update (#34589)" (#34730)

This reverts commit d0400a1.

PR Close #34730
atscott added a commit that referenced this pull request Jan 10, 2020
This reverts commit 8042433.

PR Close #34730
atscott added a commit that referenced this pull request Jan 10, 2020
This reverts commit 1ba6fd3.

PR Close #34730
atscott added a commit that referenced this pull request Jan 10, 2020
…o rules_nodejs 1.0.0 (#34589)" (#34730)

This reverts commit 7203169.

PR Close #34730
atscott added a commit that referenced this pull request Jan 10, 2020
…npm naming (#34589)" (#34730)

This reverts commit 053b23d.

PR Close #34730
atscott added a commit that referenced this pull request Jan 10, 2020
…)" (#34730)

This reverts commit 9bb349e.

PR Close #34730
atscott added a commit that referenced this pull request Jan 10, 2020
This reverts commit 96643e7.

PR Close #34730
atscott added a commit that referenced this pull request Jan 10, 2020
atscott added a commit that referenced this pull request Jan 10, 2020
atscott added a commit that referenced this pull request Jan 10, 2020
atscott added a commit that referenced this pull request Jan 10, 2020
atscott added a commit that referenced this pull request Jan 10, 2020
…label if it ends in `_es5` (#34589)" (#34730)

This reverts commit 79a0d00.

PR Close #34730
atscott added a commit that referenced this pull request Jan 10, 2020
atscott added a commit that referenced this pull request Jan 10, 2020
atscott added a commit that referenced this pull request Jan 10, 2020
atscott added a commit that referenced this pull request Jan 10, 2020
…ng additional_root_paths (#34589)" (#34730)

This reverts commit 3fda893.

PR Close #34730
atscott added a commit that referenced this pull request Jan 10, 2020
atscott added a commit that referenced this pull request Jan 10, 2020
atscott added a commit that referenced this pull request Jan 10, 2020
…ules_nodejs 1.0 update (#34589)" (#34730)

This reverts commit d0400a1.

PR Close #34730
atscott added a commit that referenced this pull request Jan 10, 2020
atscott added a commit that referenced this pull request Jan 10, 2020
atscott added a commit that referenced this pull request Jan 10, 2020
atscott added a commit that referenced this pull request Jan 10, 2020
atscott added a commit that referenced this pull request Jan 10, 2020
atscott added a commit that referenced this pull request Jan 10, 2020
atscott added a commit that referenced this pull request Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.