Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(core): avoid recursive scope recalculation when TestBed.overrideModule is used #35454

Closed
wants to merge 1 commit into from
Closed

perf(core): avoid recursive scope recalculation when TestBed.overrideModule is used #35454

wants to merge 1 commit into from

Commits on Feb 22, 2020

  1. perf(core): avoid recursive scope recalculation when TestBed.override… 

    …Module is used

Currently if TestBed detects that TestBed.overrideModule was used for module X, transitive scopes are recalculated recursively for all modules that X imports and previously calculated data (stored in cache) is ignored. This behavior was introduced in angular#33787 to fix stale transitive scopes issue (cache was not updated if module overrides are present).

The perf issue comes from a "diamond" problem, where module X is overridden which imports modules A and B, which both import module C. Under previous logic, module C gets its transitive deps recomputed multiple times, during the recompute for both A and B. For deep graphs and big common/shared modules this can be super costly.

This commit updates the logic to recalculate ransitive scopes for the overridden module, while keeping previously calculated scopes of other modules untouched.
    @AndrewKushnir
    AndrewKushnir committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    4547030 View commit details
    Browse the repository at this point in the history