Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(compiler): remove whitespace in spans #36169

Closed
wants to merge 1 commit into from

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Mar 20, 2020

#36133 and #35986
caused a conflict in test after they both got merged to master.
This PR fixes the failed tests.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

angular#36133 and angular#35986
caused a conflict in test after they both got merged to master.
This PR fixes the failed tests.
@kyliau kyliau added target: major This PR is targeted for the next major release area: compiler Issues related to `ngc`, Angular's template compiler labels Mar 20, 2020
@ngbot ngbot bot added this to the needsTriage milestone Mar 20, 2020
@kyliau kyliau added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Mar 20, 2020
@AndrewKushnir
Copy link
Contributor

Thanks for the fix @kyliau! 👍

@AndrewKushnir AndrewKushnir added the action: merge The PR is ready for merge by the caretaker label Mar 20, 2020
@mhevery mhevery closed this in ae3eaf8 Mar 20, 2020
mhevery pushed a commit that referenced this pull request Mar 20, 2020
#36133 and #35986
caused a conflict in test after they both got merged to master.
This PR fixes the failed tests.

PR Close #36169
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants