Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add documentation for ngNonBindable #36560

Closed
wants to merge 1 commit into from
Closed

docs: add documentation for ngNonBindable #36560

wants to merge 1 commit into from

Conversation

ajitsinghkaler
Copy link
Contributor

Ng non-bindable documentation was not present added documentation for ng non-bindable

@kapunahelewong was adding this documentation in #28577 asked me to take over for her as she doesn't have time to complete

Fixes #28577 #19497

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

no ngNonBindable documentation

Issue Number: #19497

What is the new behavior?

added ngNonBindable documentation

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from mhevery April 10, 2020 15:11
@ajitsinghkaler ajitsinghkaler mentioned this pull request Apr 10, 2020
Closed
14 tasks
@ajitsinghkaler
Copy link
Contributor Author

This needs engineering review and finalizations

@aikithoughts aikithoughts self-requested a review April 10, 2020 17:51
@ngbot ngbot bot added this to the Backlog milestone Apr 10, 2020
@kapunahelewong kapunahelewong added the target: patch This PR is targeted for the next patch release label Apr 10, 2020
@kapunahelewong kapunahelewong added this to In Review in docs Apr 13, 2020
aikithoughts
aikithoughts reviewed Apr 14, 2020
View reviewed changes
Copy link
Contributor

@aikithoughts aikithoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I have offered a few minor suggestions

aio/content/guide/attribute-directives.md Outdated Show resolved Hide resolved
aio/content/guide/attribute-directives.md Outdated Show resolved Hide resolved
aio/content/guide/attribute-directives.md Outdated Show resolved Hide resolved
@ajitsinghkaler
Copy link
Contributor Author

@aikidave made the changes please have a look

rafaelss95
rafaelss95 reviewed Apr 15, 2020
View reviewed changes
aio/content/guide/attribute-directives.md Outdated
and will not display `2`. This is helpful when you want to render code in the browser.

When you apply `ngNonBindable` to an element, it stops any binding starting at that element, including child elements. However, `ngNonBindable` still allows
directives to work to the element where you apply`ngNonBindable`. In the following example, the `appHighlight` directive will still be active but Angular will not evaluate the expression `{{ 1 +1 }}`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excuse me, If I could give my two cents here, I think there are missing whitespaces:

  • After "apply" word;
  • After plus sign (there are other ocurrences also in file "app.component.html");
Suggested change
directives to work to the element where you apply`ngNonBindable`. In the following example, the `appHighlight` directive will still be active but Angular will not evaluate the expression `{{ 1 +1 }}`.
directives to work to the element where you apply `ngNonBindable`. In the following example, the `appHighlight` directive will still be active but Angular will not evaluate the expression `{{ 1 + 1 }}`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks will add them in the changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, @rafaelss95!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made the changes @aikidave please have a look

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajitsinghkaler it seems like you forgot to change it in the app.component.html also 👀

@ajitsinghkaler
Copy link
Contributor Author

@mhevery can ou please have a look

@ajitsinghkaler
Copy link
Contributor Author

@mhevery can you please have a look

@ajitsinghkaler
Copy link
Contributor Author

@mhevery can you please review this

@aikidave can you please put a tag that it needs eng input

@ajitsinghkaler
docs: add documentation for ngNonBindable
589859d 
ngNonBindable documentation was not present, on docs site added documentation for ngNonBindable. With this template primitive, Angular won't
evaluate expressions in elements.

Fixes angular#28577 Fixes angular#19497
@kapunahelewong kapunahelewong added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jun 15, 2020
@ajitsinghkaler
Copy link
Contributor Author

@mhevery can you please review this

@mhevery mhevery removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 17, 2020
@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Nov 17, 2020
atscott pushed a commit that referenced this pull request Nov 17, 2020
@ajitsinghkaler @atscott
docs: add documentation for ngNonBindable (#36560)
a88bc64 
ngNonBindable documentation was not present, on docs site added documentation for ngNonBindable. With this template primitive, Angular won't
evaluate expressions in elements.

Fixes #28577 Fixes #19497

PR Close #36560
@atscott atscott closed this in 806d7aa Nov 17, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 19, 2020
@pullapprove pullapprove bot added area: core Issues related to the framework runtime and removed comp: docs labels Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rafaelss95 rafaelss95 rafaelss95 left review comments

@mhevery mhevery mhevery approved these changes

@aikithoughts aikithoughts aikithoughts approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes effort2: days feature Issue that requests a new feature risk: low state: needs eng input target: patch This PR is targeted for the next patch release
Projects
docs
In Review
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ajitsinghkaler @mhevery @rafaelss95 @aikithoughts @kapunahelewong @googlebot