-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate Bazel builder in @angular/bazel #37190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the README.md needs some more work and likely devrel input. Can you please get @mgechev and @StephenFluin to weigh in on the wording? We'll also need @aikidave to look at this before it hits angular.io in June.
In general we don't want to freak people out with this removal. It's not that we don't like Bazel (some of us very much do! 😃), we just found out that our current approach to jam bazel into Angular CLI is not the right one, and we need to pivot. Instead of wrapping Bazel into Angular CLI we found a way how bazel and Angular CLI can coexist for some workflows and for others it's actually better if Bazel wraps Angular CLI.
In order to enable this pivot, we must deprecate the current integration. For people that depend on Angular CLI + Bazel, they can keep on building their apps with the existing rules (ng_module
, ng_package
, etc), but we don't want new projects to onboard in this way any more.
In the future, we'll most likely remove all of these custom rules and replace them with direct integration from bazel to ngc
, etc. But we are nowhere close to that. We'll revisit how this stuff should work once we remove View Engine from our code base and Ivy is the only compilation pipeline out there.
) This commit removes the fields for ng-add, schematics and builder from package.json of `@angular/bazel`. PR Close #37190
This commit improves some wording in the deprecation doc for Bazel builder and schematics in `@angular/bazel` and fixes the formatting. PR Close #37190
This commit adds a link to the Bazel prototype for orchestrating multiple CLI architects and also adds a link to the #angular channel in the Bazel Slack workspace. PR Close #37190
This commit adds a deprecation doc for Bazel builder in `@angular/bazel` and removes the corresponding guide in angular.io. PR Close angular#37190
This commit removes `ng-add` and `ng-new` schematics for the Bazel Builder, and update the corresponding BUILD files. PR Close angular#37190
This commit removes "Building with Bazel" section from angular.io navigation list and Angular CLI landing page. PR Close angular#37190
This commit removes aio/content/guide/bazel.md from the Bazel list in pullapprove since Bazel builder has been deprecated and the doc has been deleted. PR Close angular#37190
This commit removes the integration test for schematics in `@angular/bazel` that is used to generate a Bazel builder. The Bazel builder has been deprecated. PR Close angular#37190
…ar#37190) This commit adds a 301 redirect for /guide/bazel on angular.io to the deprecation doc for Angular Bazel schematics in Angular repo. PR Close angular#37190
This commit adds an exception for "guide/bazel" to the navigationUrls in the Service Worker config. This is needed for redirection to work. PR Close angular#37190
…ular#37190) This commit removes the fields for ng-add, schematics and builder from package.json of `@angular/bazel`. PR Close angular#37190
This commit improves some wording in the deprecation doc for Bazel builder and schematics in `@angular/bazel` and fixes the formatting. PR Close angular#37190
…7190) This commit adds a link to the Bazel prototype for orchestrating multiple CLI architects and also adds a link to the #angular channel in the Bazel Slack workspace. PR Close angular#37190
…ngular#37190) This commit adds Bazel builder and schematics to the global list of deprecations in Angular. A link to the migration doc is added. PR Close angular#37190
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This commit adds a deprecation doc for Bazel builder in `@angular/bazel` and removes the corresponding guide in angular.io. PR Close angular#37190
This commit removes `ng-add` and `ng-new` schematics for the Bazel Builder, and update the corresponding BUILD files. PR Close angular#37190
This commit removes "Building with Bazel" section from angular.io navigation list and Angular CLI landing page. PR Close angular#37190
This commit removes aio/content/guide/bazel.md from the Bazel list in pullapprove since Bazel builder has been deprecated and the doc has been deleted. PR Close angular#37190
This commit removes the integration test for schematics in `@angular/bazel` that is used to generate a Bazel builder. The Bazel builder has been deprecated. PR Close angular#37190
…ar#37190) This commit adds a 301 redirect for /guide/bazel on angular.io to the deprecation doc for Angular Bazel schematics in Angular repo. PR Close angular#37190
This commit adds an exception for "guide/bazel" to the navigationUrls in the Service Worker config. This is needed for redirection to work. PR Close angular#37190
…ular#37190) This commit removes the fields for ng-add, schematics and builder from package.json of `@angular/bazel`. PR Close angular#37190
This commit improves some wording in the deprecation doc for Bazel builder and schematics in `@angular/bazel` and fixes the formatting. PR Close angular#37190
…7190) This commit adds a link to the Bazel prototype for orchestrating multiple CLI architects and also adds a link to the #angular channel in the Bazel Slack workspace. PR Close angular#37190
…ngular#37190) This commit adds Bazel builder and schematics to the global list of deprecations in Angular. A link to the migration doc is added. PR Close angular#37190
This PR removes the schematics for Bazel builder from
@angular/bazel
.It consists of a few commits:
@angular/bazel
schematics code, mainlyng-add
andng-new
, and the Bazel builder.aio/content/guide/bazel.md
from pullapprovebazel-schematics
integration testguide/bazel
to deprecation doc in Angular repoPR closes #19058
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information