build(docs-infra): update Angular framework/Components/CLI to latest versions #37898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
added
area: build & ci
|
You can preview 1ec42dc at https://pr37898-1ec42dc.ngbuilds.io/. |
|
You can preview 38f1f24 at https://pr37898-38f1f24.ngbuilds.io/. |
gkalpak
force-pushed
the
build-aio-update-angular-deps
branch
from
38f1f24
to
4641ee5
Compare
|
You can preview 4641ee5 at https://pr37898-4641ee5.ngbuilds.io/. |
petebacondarwin
approved these changes
Jul 3, 2020
| @@ -3,7 +3,7 @@ | |||
| "master": { | |||
| "uncompressed": { | |||
| "runtime-es2015": 2987, | |||
| "main-es2015": 453213, | |||
| "main-es2015": 450880, | |||
There was a problem hiding this comment.
Yes 🎉 (Part of it is the framework and part of it is Components.)
gkalpak
added
action: merge
pullapprove
bot
requested review from
alxhub,
IgorMinar,
jelbourn and
pkozlowski-opensource
pkozlowski-opensource
approved these changes
Jul 6, 2020
pkozlowski-opensource
approved these changes
Jul 6, 2020
jelbourn
approved these changes
Jul 7, 2020
| @@ -6,21 +6,27 @@ describe('CustomIconRegistry', () => { | |||
| const mockHttp: any = {}; | |||
| const mockSanitizer: any = {}; | |||
| const mockDocument: any = {}; | |||
| const mockErrorHandler: any = {}; | |||
There was a problem hiding this comment.
I wouldn't block submission on this, but I would do
const fakeErrorHandler = {
handleError: e => { console.error(e); },
};There was a problem hiding this comment.
Updated.
(Also updated the other names from mock* to fake* (since they are more fakes than mocks - although arguably they are neither 😁).
| const registry = new CustomIconRegistry(mockHttp, mockSanitizer, mockDocument, svgIcons); | ||
|
|
||
| const registry = | ||
| new CustomIconRegistry(mockHttp, mockSanitizer, mockDocument, mockErrorHandler, svgIcons); |
There was a problem hiding this comment.
FYI there's actually an "official" FakeMatIconRegistry in @angular/material/icon/testing now
There was a problem hiding this comment.
👍
For future reference, we are testing our custom MatIconRegistry here, so using FakeMatIconRegistry is not applicable.
This commit updates the version of Angular framework used in angular.io to version 10.0.2. It also features a commit message with a 100+ chars long body.
This commit updates the version of Angular Components used in angular.io to version 10.0.1. It also updates the angular.io app to adapt to breaking changes.
This commit removes some duplicate imports of Material themes and theming-related utilities. While this change does not have any impact on the size of the generated `styles.css` file, it silences a build warning pointing to [Avoiding duplicated theming styles][1]. [1]: https://github.com/angular/components/blob/db4b0cd1bff0bbb1741d22975bcfe1069aea3a53/guides/duplicate-theming-styles.md
This commit updates the version of Angular CLI used in angular.io to version 10.0.1. It also reverts some changes (namely commits 38dfbc7 and eee2fd2) which were made due to an older bug that is fixed in the latest version. See angular#37688 for more details. Fixes angular#37699
gkalpak
force-pushed
the
build-aio-update-angular-deps
branch
from
4641ee5
to
f1c1872
Compare
gkalpak
force-pushed
the
build-aio-update-angular-deps
branch
from
f1c1872
to
574620f
Compare
|
You can preview 574620f at https://pr37898-574620f.ngbuilds.io/. |
alxhub
approved these changes
Jul 7, 2020
atscott
pushed a commit
that referenced
this pull request
Jul 8, 2020
This commit updates the version of Angular framework used in angular.io to version 10.0.2. It also features a commit message with a 100+ chars long body. PR Close #37898
atscott
pushed a commit
that referenced
this pull request
Jul 8, 2020
This commit updates the version of Angular Components used in angular.io to version 10.0.1. It also updates the angular.io app to adapt to breaking changes. PR Close #37898
atscott
pushed a commit
that referenced
this pull request
Jul 8, 2020
This commit removes some duplicate imports of Material themes and theming-related utilities. While this change does not have any impact on the size of the generated `styles.css` file, it silences a build warning pointing to [Avoiding duplicated theming styles][1]. [1]: https://github.com/angular/components/blob/db4b0cd1bff0bbb1741d22975bcfe1069aea3a53/guides/duplicate-theming-styles.md PR Close #37898
atscott
pushed a commit
that referenced
this pull request
Jul 8, 2020
This commit updates the version of Angular Components used in angular.io to version 10.0.1. It also updates the angular.io app to adapt to breaking changes. PR Close #37898
atscott
pushed a commit
that referenced
this pull request
Jul 8, 2020
This commit removes some duplicate imports of Material themes and theming-related utilities. While this change does not have any impact on the size of the generated `styles.css` file, it silences a build warning pointing to [Avoiding duplicated theming styles][1]. [1]: https://github.com/angular/components/blob/db4b0cd1bff0bbb1741d22975bcfe1069aea3a53/guides/duplicate-theming-styles.md PR Close #37898
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
This commit updates the version of Angular framework used in angular.io to version 10.0.2. It also features a commit message with a 100+ chars long body. PR Close angular#37898
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
This commit updates the version of Angular Components used in angular.io to version 10.0.1. It also updates the angular.io app to adapt to breaking changes. PR Close angular#37898
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
…ar#37898) This commit removes some duplicate imports of Material themes and theming-related utilities. While this change does not have any impact on the size of the generated `styles.css` file, it silences a build warning pointing to [Avoiding duplicated theming styles][1]. [1]: https://github.com/angular/components/blob/db4b0cd1bff0bbb1741d22975bcfe1069aea3a53/guides/duplicate-theming-styles.md PR Close angular#37898
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
This commit updates the version of Angular CLI used in angular.io to version 10.0.1. It also reverts some changes (namely commits 38dfbc7 and eee2fd2) which were made due to an older bug that is fixed in the latest version. See angular#37688 for more details. Fixes angular#37699 PR Close angular#37898
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR updates Angular framework to v10.0.2, Angular Components to v10.0.1 and Angular CLI to v10.0.1. See individual commits for more details.
Fixes #37699.