Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-cli): ensure file_system handles mixed Windows drives BACKPORT #38030

Commits on Jul 13, 2020

  1. fix(compiler-cli): ensure file_system handles mixed Windows drives

    The `fs.relative()` method assumed that the file-system is a single tree,
    which is not the case in Windows, where you can have multiple drives,
    e.g. `C:`, `D:` etc.
    
    This commit changes `fs.relative()` so that it no longer forces the result
    to be a `PathSegment` and then flows that refactoring through the rest of
    the compiler-cli (and ngcc).  The main difference is that now, in some cases,
    we needed to check whether the result is "rooted", i.e an `AbsoluteFsPath`,
    rather than a `PathSegment`, before using it.
    
    Fixes angular#36777
    petebacondarwin committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    25b9696 View commit details
    Browse the repository at this point in the history