feat(service-worker): add the option to prefer network for navigation… #38565

klemenoslaj · 2020-08-24T20:35:14Z

… requests

This commit introduces a new option for the service worker, called
navigationRequestStrategy, which adds the possibility to force the service worker
to always create a network request for navigation requests.
This enables the server redirects while retaining the offline behavior.

Fixes #38194

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Issue Number: #38194, #36099

What is the new behavior?

After enabling the freashnessForNavigationUrls flag, the navigation requests will always go through the network.
This will enable the HTTP redirects.

Does this PR introduce a breaking change?

Yes
No

Other information

gkalpak

This looks great, @klemenoslaj 🎉
I left some minor comments, but otherwise lgtm. Impressive work (esp. for a first-time contribution) 🙇

packages/service-worker/config/src/in.ts

packages/service-worker/worker/src/app-version.ts

aio/content/guide/service-worker-config.md

packages/service-worker/config/schema.json

packages/service-worker/worker/test/happy_spec.ts

packages/service-worker/worker/src/manifest.ts

klemenoslaj

@gkalpak I made the suggested changes. Please have a look.

packages/service-worker/config/src/in.ts

gkalpak

Nice, this is pretty close to ready 🎉
Here's another round of review (just minor comments) 😃

packages/service-worker/worker/test/happy_spec.ts

packages/service-worker/config/schema.json

packages/service-worker/worker/src/manifest.ts

packages/service-worker/worker/src/app-version.ts

packages/service-worker/worker/test/happy_spec.ts

aio/content/guide/service-worker-config.md

gkalpak

Thx for making the changes, @klemenoslaj 👍
The code looks great. Just some more comments regarding docs 📖

packages/service-worker/worker/src/app-version.ts

aio/content/guide/service-worker-config.md

mary-poppins · 2020-09-18T07:41:39Z

You can preview 21009e8 at https://pr38565-21009e8.ngbuilds.io/.

kapunahelewong

Never mind! I didn't realize that @aikidave had already reviewed! I had it up partially completed yesterday. Deleting my comments!

Review comments deleted by reviewer.

aio/content/guide/service-worker-config.md

mary-poppins · 2020-09-19T14:02:14Z

You can preview f84d919 at https://pr38565-f84d919.ngbuilds.io/.

aikithoughts

A minor comment, but nothing blocking. Otherwise, LGTM.

Reviewed-for: required-docs-approvers

aio/content/guide/service-worker-config.md

… requests This commit introduces a new option for the service worker, called `navigationRequestStrategy`, which adds the possibility to force the service worker to always create a network request for navigation requests. This enables the server redirects while retaining the offline behavior. Fixes angular#38194

mary-poppins · 2020-09-22T06:39:46Z

You can preview 2025600 at https://pr38565-2025600.ngbuilds.io/.

angular-automatic-lock-bot · 2020-10-23T16:32:10Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Aug 24, 2020

sonukapoor added the area: service-worker Issues related to the @angular/service-worker package label Aug 25, 2020

ngbot bot added this to the needsTriage milestone Aug 25, 2020

klemenoslaj force-pushed the service-worker-navigate-request-freshness branch from 6d061f5 to bfa9d7e Compare August 25, 2020 23:24

klemenoslaj marked this pull request as ready for review August 26, 2020 10:14

pullapprove bot requested review from gkalpak and pkozlowski-opensource August 26, 2020 10:15

gkalpak requested changes Aug 27, 2020

View reviewed changes

sonukapoor added the feature Issue that requests a new feature label Aug 27, 2020

klemenoslaj force-pushed the service-worker-navigate-request-freshness branch 3 times, most recently from 8cbc687 to 63b2763 Compare August 28, 2020 07:44

alfaproject reviewed Aug 28, 2020

View reviewed changes

packages/service-worker/worker/src/manifest.ts Outdated Show resolved Hide resolved

klemenoslaj force-pushed the service-worker-navigate-request-freshness branch from 63b2763 to ac19cce Compare August 28, 2020 08:12

klemenoslaj requested a review from gkalpak August 28, 2020 08:12

klemenoslaj force-pushed the service-worker-navigate-request-freshness branch from ac19cce to 0e3a0c0 Compare August 28, 2020 11:26

klemenoslaj commented Aug 28, 2020

View reviewed changes

packages/service-worker/config/src/in.ts Show resolved Hide resolved

klemenoslaj force-pushed the service-worker-navigate-request-freshness branch 3 times, most recently from 47ebeca to 015fbf8 Compare August 28, 2020 14:00

gkalpak requested changes Sep 3, 2020

View reviewed changes

klemenoslaj force-pushed the service-worker-navigate-request-freshness branch 2 times, most recently from 54e9347 to 51d3afc Compare September 3, 2020 13:38

klemenoslaj requested a review from gkalpak September 3, 2020 15:57

klemenoslaj force-pushed the service-worker-navigate-request-freshness branch 2 times, most recently from 9281001 to 60c547c Compare September 4, 2020 09:52

gkalpak requested changes Sep 6, 2020

View reviewed changes

klemenoslaj force-pushed the service-worker-navigate-request-freshness branch from 60c547c to 23f6bda Compare September 6, 2020 20:34

klemenoslaj requested a review from gkalpak September 6, 2020 20:34

gkalpak added the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 7, 2020

klemenoslaj force-pushed the service-worker-navigate-request-freshness branch 2 times, most recently from a52c5b3 to 21009e8 Compare September 18, 2020 07:28

kapunahelewong previously requested changes Sep 18, 2020

View reviewed changes

kapunahelewong requested review from kapunahelewong and removed request for kapunahelewong September 18, 2020 12:50

gkalpak removed the request for review from kapunahelewong September 19, 2020 09:40

gkalpak requested changes Sep 19, 2020

View reviewed changes

aio/content/guide/service-worker-config.md Outdated Show resolved Hide resolved

aio/content/guide/service-worker-config.md Outdated Show resolved Hide resolved

aio/content/guide/service-worker-config.md Outdated Show resolved Hide resolved

gkalpak added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Sep 19, 2020

klemenoslaj force-pushed the service-worker-navigate-request-freshness branch from 21009e8 to f84d919 Compare September 19, 2020 13:54

klemenoslaj requested a review from gkalpak September 19, 2020 13:54

gkalpak approved these changes Sep 20, 2020

View reviewed changes

klemenoslaj mentioned this pull request Sep 21, 2020

Angular Service worker incorrectly intercepting http redirects (302) #38194

Closed

gkalpak added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Sep 21, 2020

aikithoughts approved these changes Sep 21, 2020

View reviewed changes

aio/content/guide/service-worker-config.md Outdated Show resolved Hide resolved

klemenoslaj force-pushed the service-worker-navigate-request-freshness branch from f84d919 to 2025600 Compare September 22, 2020 06:25

gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 22, 2020

gkalpak mentioned this pull request Sep 22, 2020

ServiceWorker doesn't update index.html when headers (e.g. CSP) change #37390

Open

mhevery closed this in a206852 Sep 22, 2020

gkalpak mentioned this pull request Sep 27, 2020

Service Worker: allow service worker to checkForUpdate and activateUpdate before bootstraping the AppModule #39008

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(service-worker): add the option to prefer network for navigation… #38565

feat(service-worker): add the option to prefer network for navigation… #38565

klemenoslaj commented Aug 24, 2020 •

edited

Loading

gkalpak left a comment

klemenoslaj left a comment

gkalpak left a comment

gkalpak left a comment

mary-poppins commented Sep 18, 2020

kapunahelewong left a comment •

edited

Loading

mary-poppins commented Sep 19, 2020

aikithoughts left a comment

mary-poppins commented Sep 22, 2020

angular-automatic-lock-bot bot commented Oct 23, 2020

feat(service-worker): add the option to prefer network for navigation… #38565

feat(service-worker): add the option to prefer network for navigation… #38565

Conversation

klemenoslaj commented Aug 24, 2020 • edited Loading

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

gkalpak left a comment

Choose a reason for hiding this comment

klemenoslaj left a comment

Choose a reason for hiding this comment

gkalpak left a comment

Choose a reason for hiding this comment

gkalpak left a comment

Choose a reason for hiding this comment

mary-poppins commented Sep 18, 2020

kapunahelewong left a comment • edited Loading

Choose a reason for hiding this comment

mary-poppins commented Sep 19, 2020

aikithoughts left a comment

Choose a reason for hiding this comment

mary-poppins commented Sep 22, 2020

angular-automatic-lock-bot bot commented Oct 23, 2020

klemenoslaj commented Aug 24, 2020 •

edited

Loading

kapunahelewong left a comment •

edited

Loading