Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(compiler-cli): migrate view compliance tests #39914

Closed
wants to merge 1 commit into from
Closed

test(compiler-cli): migrate view compliance tests #39914

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 1, 2020

Migrates the r3_view_compiler tests to the new format.

@google-cla google-cla bot added the cla: yes label Dec 1, 2020
@crisbeto
test(compiler-cli): migrate view compliance tests
625e449 
Migrates the `r3_view_compiler` tests to the new format.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer area: compiler Issues related to `ngc`, Angular's template compiler refactoring Issue that involves refactoring or code-cleanup target: minor This PR is targeted for the next minor release labels Dec 1, 2020
@ngbot ngbot bot added this to the needsTriage milestone Dec 1, 2020
@crisbeto crisbeto marked this pull request as ready for review December 1, 2020 18:33
@pullapprove pullapprove bot requested a review from JoostK December 1, 2020 18:34
JoostK
JoostK approved these changes Dec 1, 2020
View reviewed changes
packages/compiler-cli/test/compliance/test_cases/r3_view_compiler/hello_world/test.js
Comment on lines +3 to +4
MyComponent.ɵfac = …;
MyComponent.ɵcmp = …;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow these look like early tests!

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 1, 2020
@jessicajaniuk jessicajaniuk removed the request for review from petebacondarwin December 1, 2020 23:10
@jessicajaniuk
Copy link
Contributor

Proceeding with the merge since all necessary approvals are granted, but a new PR can be created if there's any additional feedback.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoostK JoostK JoostK approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler cla: yes refactoring Issue that involves refactoring or code-cleanup target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @jessicajaniuk @JoostK