Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-cli): Allow analysis to continue with invalid style url #41403

Closed
wants to merge 2 commits into from

Commits on Apr 5, 2021

  1. fix(compiler-cli): Allow analysis to continue with invalid style url

    Currently, we throw a FatalDiagnosticError when we fail to load a resource
    (`templateUrl` or `styleUrl`) at various stages in the compiler. This prevents
    analysis of the component from completing. This will result in in users not being
    able to get any information in the component template when there is a missing
    `styleUrl`, for example.
    
    This commit simply tracks the diagnostic, marks the component as poisoned, and
    continues merrily along. Environments configured to use poisoned data
    (like the language service) will then be able to use other information from the analysis.
    
    Fixes angular/vscode-ng-language-service#1241
    atscott committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    6fe6bda View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2021

  1. Configuration menu
    Copy the full SHA
    d0b2af3 View commit details
    Browse the repository at this point in the history