Be more tolerant of missing resources #1241
Assignees
Labels
Comments
atscott
added a commit
to atscott/angular
that referenced
this issue
Mar 31, 2021
Currently, we throw a FatalDiagnosticError when we fail to load a resource (`templateUrl` or `styleUrl`) at various stages in the compiler. This prevents analysis of the component from completing. This will result in in users not being able to get any information in the component template when there is a missing `styleUrl`, for example. This commit simply tracks the diagnostic, marks the component as poisoned, and continues merrily along. Environments configured to use poisoned data (like the language service) will then be able to use other information from the analysis. Fixes angular/vscode-ng-language-service#1241
atscott
added a commit
to atscott/angular
that referenced
this issue
Mar 31, 2021
Currently, we throw a FatalDiagnosticError when we fail to load a resource (`templateUrl` or `styleUrl`) at various stages in the compiler. This prevents analysis of the component from completing. This will result in in users not being able to get any information in the component template when there is a missing `styleUrl`, for example. This commit simply tracks the diagnostic, marks the component as poisoned, and continues merrily along. Environments configured to use poisoned data (like the language service) will then be able to use other information from the analysis. Fixes angular/vscode-ng-language-service#1241
atscott
added a commit
to atscott/angular
that referenced
this issue
Mar 31, 2021
Currently, we throw a FatalDiagnosticError when we fail to load a resource (`templateUrl` or `styleUrl`) at various stages in the compiler. This prevents analysis of the component from completing. This will result in in users not being able to get any information in the component template when there is a missing `styleUrl`, for example. This commit simply tracks the diagnostic, marks the component as poisoned, and continues merrily along. Environments configured to use poisoned data (like the language service) will then be able to use other information from the analysis. Fixes angular/vscode-ng-language-service#1241
atscott
added a commit
to atscott/angular
that referenced
this issue
Apr 1, 2021
Currently, we throw a FatalDiagnosticError when we fail to load a resource (`templateUrl` or `styleUrl`) at various stages in the compiler. This prevents analysis of the component from completing. This will result in in users not being able to get any information in the component template when there is a missing `styleUrl`, for example. This commit simply tracks the diagnostic, marks the component as poisoned, and continues merrily along. Environments configured to use poisoned data (like the language service) will then be able to use other information from the analysis. Fixes angular/vscode-ng-language-service#1241
atscott
added a commit
to atscott/angular
that referenced
this issue
Apr 5, 2021
Currently, we throw a FatalDiagnosticError when we fail to load a resource (`templateUrl` or `styleUrl`) at various stages in the compiler. This prevents analysis of the component from completing. This will result in in users not being able to get any information in the component template when there is a missing `styleUrl`, for example. This commit simply tracks the diagnostic, marks the component as poisoned, and continues merrily along. Environments configured to use poisoned data (like the language service) will then be able to use other information from the analysis. Fixes angular/vscode-ng-language-service#1241
atscott
added a commit
to atscott/angular
that referenced
this issue
Apr 7, 2021
…ngular#41403) Currently, we throw a FatalDiagnosticError when we fail to load a resource (`templateUrl` or `styleUrl`) at various stages in the compiler. This prevents analysis of the component from completing. This will result in in users not being able to get any information in the component template when there is a missing `styleUrl`, for example. This commit simply tracks the diagnostic, marks the component as poisoned, and continues merrily along. Environments configured to use poisoned data (like the language service) will then be able to use other information from the analysis. Fixes angular/vscode-ng-language-service#1241 PR Close angular#41403
atscott
added a commit
to atscott/angular
that referenced
this issue
Apr 7, 2021
…ngular#41403) Currently, we throw a FatalDiagnosticError when we fail to load a resource (`templateUrl` or `styleUrl`) at various stages in the compiler. This prevents analysis of the component from completing. This will result in in users not being able to get any information in the component template when there is a missing `styleUrl`, for example. This commit simply tracks the diagnostic, marks the component as poisoned, and continues merrily along. Environments configured to use poisoned data (like the language service) will then be able to use other information from the analysis. Fixes angular/vscode-ng-language-service#1241 PR Close angular#41403
atscott
added a commit
to atscott/angular
that referenced
this issue
Apr 7, 2021
…ngular#41403) Currently, we throw a FatalDiagnosticError when we fail to load a resource (`templateUrl` or `styleUrl`) at various stages in the compiler. This prevents analysis of the component from completing. This will result in in users not being able to get any information in the component template when there is a missing `styleUrl`, for example. This commit simply tracks the diagnostic, marks the component as poisoned, and continues merrily along. Environments configured to use poisoned data (like the language service) will then be able to use other information from the analysis. Fixes angular/vscode-ng-language-service#1241 PR Close angular#41403
atscott
added a commit
to angular/angular
that referenced
this issue
Apr 7, 2021
…41403) (#41489) Currently, we throw a FatalDiagnosticError when we fail to load a resource (`templateUrl` or `styleUrl`) at various stages in the compiler. This prevents analysis of the component from completing. This will result in in users not being able to get any information in the component template when there is a missing `styleUrl`, for example. This commit simply tracks the diagnostic, marks the component as poisoned, and continues merrily along. Environments configured to use poisoned data (like the language service) will then be able to use other information from the analysis. Fixes angular/vscode-ng-language-service#1241 PR Close #41403 PR Close #41489
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently, we throw a
FatalDiagnosticErrorwhen we fail to load a resource (templateUrlorstyleUrl) at various stages in the compiler. This prevents analysis of the component from completing. This will result in in users not being able to get any information in the component template when there is a missingstyleUrl, for example. Instead, we should simply track the diagnostic, mark the component as poisoned, and continue [somewhat] merrily along. Environments configured to use poisoned data (like the language service) will then be able to use other information from the analysis.The text was updated successfully, but these errors were encountered: