fix(dev-infra): do not set lts dist tag on packages from release-candidate/feature-freeze release-train #41946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idate train Currently if a major release-train in the `release-candidate`/`feature-freeze` phase becomes `latest`, we intend to set the NPM LTS dist tag for all packages of the previous major (as the old release train in `latest` moves into LTS phase). The logic for this exists but the release tool sets the NPM dist tag for all packages of the new major. This means that the script might error if a new package is part of the new major; or it could cause a deleted package to not receive the LTS tag properly.
devversion
added
action: review
devversion
added
action: merge
mhevery
pushed a commit
that referenced
this pull request
May 5, 2021
…idate train (#41946) Currently if a major release-train in the `release-candidate`/`feature-freeze` phase becomes `latest`, we intend to set the NPM LTS dist tag for all packages of the previous major (as the old release train in `latest` moves into LTS phase). The logic for this exists but the release tool sets the NPM dist tag for all packages of the new major. This means that the script might error if a new package is part of the new major; or it could cause a deleted package to not receive the LTS tag properly. PR Close #41946
mhevery
pushed a commit
that referenced
this pull request
May 5, 2021
…idate train (#41946) Currently if a major release-train in the `release-candidate`/`feature-freeze` phase becomes `latest`, we intend to set the NPM LTS dist tag for all packages of the previous major (as the old release train in `latest` moves into LTS phase). The logic for this exists but the release tool sets the NPM dist tag for all packages of the new major. This means that the script might error if a new package is part of the new major; or it could cause a deleted package to not receive the LTS tag properly. PR Close #41946
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a major release-train in the
release-candidate/feature-freezephase becomes
latest, we intend to set the NPM LTS dist tag for all packagesof the previous major (as the old release train in
latestmoves into LTS phase).The logic for this exists but the release tool sets the NPM dist tag for
all packages of the new major. This means that the script might error if
a new package is part of the new major; or it could cause a deleted
package to not receive the LTS tag properly.