Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update @microsoft/api-extractor to 7.18.1 #42804

Closed
wants to merge 3 commits into from
Closed

build: update @microsoft/api-extractor to 7.18.1 #42804

wants to merge 3 commits into from

Conversation

alan-agius4
Copy link
Contributor

@google-cla google-cla bot added the cla: yes label Jul 9, 2021
@alan-agius4 alan-agius4 marked this pull request as ready for review July 9, 2021 05:22
@pullapprove pullapprove bot requested a review from kyliau July 9, 2021 05:23
@alan-agius4 alan-agius4 requested review from josephperrott and removed request for kyliau July 9, 2021 05:23
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer area: bazel Issues related to the published `@angular/bazel` build rules area: build & ci Related the build and CI infrastructure of the project area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) target: minor This PR is targeted for the next minor release labels Jul 9, 2021
@ngbot ngbot bot modified the milestone: Backlog Jul 9, 2021
devversion
devversion approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

josephperrott
josephperrott approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: time-zone labels Jul 9, 2021
@AndrewKushnir AndrewKushnir added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jul 9, 2021
@AndrewKushnir
Copy link
Contributor

@alan-agius4 FYI there is a merge conflict with the master branch atm (due to other updates to the package.json file merged earlier). Could you please rebase and resolve conflict when you get a chance? Thank you.

@AndrewKushnir AndrewKushnir removed the action: merge The PR is ready for merge by the caretaker label Jul 9, 2021
@alan-agius4
Copy link
Contributor Author

@AndrewKushnir, done!

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jul 9, 2021
AndrewKushnir pushed a commit that referenced this pull request Jul 9, 2021
@alan-agius4 @AndrewKushnir
Revert "ci: configure renovate to ignore @microsoft/api-extractor (#…
625421c 
…42797)" (#42804)

This reverts commit 1f3747b.

PR Close #42804
AndrewKushnir pushed a commit that referenced this pull request Jul 9, 2021
@alan-agius4 @AndrewKushnir
test(bazel): update example_package.golden (#42804)
9d58ebf 
This is caused by the update of @microsoft/api-extractor to 7.18.1

PR Close #42804
@alan-agius4 alan-agius4 deleted the api-extractor-bump branch July 9, 2021 19:34
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules area: build & ci Related the build and CI infrastructure of the project area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) cla: yes target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
4 participants
@alan-agius4 @AndrewKushnir @devversion @josephperrott