Assorted cleanups/fixes for ng-dev #42871
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a commit message is not restored, there is not need to log this to stdout. It is a better experience to silently succeed.
…lRequestToBeMerged `waitForPullRequestToBeMerged` should get the entire `PullRequest` object rather than just the id to allow it to have more information/context for logging and messaging.
Previously the wombot proxy was not able to be queried for login state, now that it is able to be checked via `npm whoami` a specific alternate flow is no longer needed.
josephperrott
added
action: merge
…for release Prevent logging verbose messages to the output for commit and checkout during the release process.
josephperrott
force-pushed
the
cleanup-ng-dev-things
branch
from
6cc4dea
to
3507f39
Compare
devversion
approved these changes
Jul 16, 2021
devversion
removed
the
area: dev-infra
devversion
added
the
area: dev-infra
josephperrott
added
merge: caretaker note
josephperrott
added a commit
to josephperrott/angular
that referenced
this pull request
Jul 21, 2021
…bot proxy (angular#42871)" This reverts commit fd92a3e.
josephperrott
added a commit
to josephperrott/angular
that referenced
this pull request
Jul 22, 2021
…bot proxy (angular#42871)" This reverts commit fd92a3e. It turns out that wombot proxy will return who is logged in, but does so regardless of if the users token is currently active. Since we cannot rely on `npm whoami` to determine the login state, we revert to our previous state of assuming new login is needed.
dylhunn
pushed a commit
that referenced
this pull request
Jul 22, 2021
…bot proxy (#42871)" (#42917) This reverts commit fd92a3e. It turns out that wombot proxy will return who is logged in, but does so regardless of if the users token is currently active. Since we cannot rely on `npm whoami` to determine the login state, we revert to our previous state of assuming new login is needed. PR Close #42917
dylhunn
pushed a commit
that referenced
this pull request
Jul 22, 2021
…bot proxy (#42871)" (#42917) This reverts commit fd92a3e. It turns out that wombot proxy will return who is logged in, but does so regardless of if the users token is currently active. Since we cannot rely on `npm whoami` to determine the login state, we revert to our previous state of assuming new login is needed. PR Close #42917
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.