Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(core): showcase host listener support for specific keys in events #44833

Closed
wants to merge 1 commit into from

Conversation

macjohnny
Copy link
Contributor

@macjohnny macjohnny commented Jan 26, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

See this example: https://stackblitz.com/edit/angular-ivy-u23hez?file=src/app/app.component.ts

@macjohnny
Copy link
Contributor Author

maybe we could add event more information about the keys supported. is there a pointer to the implementation?

@macjohnny
Copy link
Contributor Author

moreover, some information could be added to https://angular.io/guide/binding-syntax and https://angular.io/guide/event-binding-concepts, since <input (keydown.enter)="someHandler()" /> works as well

@pullapprove pullapprove bot requested a review from alxhub January 26, 2022 16:35
@macjohnny
Copy link
Contributor Author

macjohnny commented Jan 26, 2022

for keyboard event keys see

// cf https://www.w3.org/TR/DOM-Level-3-Events-key/

for global target names see

export type GlobalTargetName = 'document'|'window'|'body';

@macjohnny macjohnny changed the title docs(core): showcase @HostListener support for specific keys in events docs(core): showcase host listener support for specific keys in events Jan 27, 2022
@ngbot ngbot bot added this to the Backlog milestone Jan 27, 2022
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@macjohnny thanks for improving Angular docs 👍

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jan 31, 2022
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit f0d572e.

@macjohnny macjohnny deleted the patch-1 branch February 1, 2022 06:49
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants