Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Ensure the StandaloneService is retained after closure m… #45783

Closed
wants to merge 1 commit into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Apr 27, 2022

…inification

In order to survive closure minification correctly, static properties need to
be annotated with @nocollapse.

For more history, see #28050

@atscott atscott added area: core Issues related to the framework runtime target: minor This PR is targeted for the next minor release labels Apr 27, 2022
@ngbot ngbot bot added this to the Backlog milestone Apr 27, 2022
…inification

In order to survive closure minification correctly, static properties need to
be annotated with @nocollapse.

For more history, see angular#28050
@atscott
Copy link
Contributor Author

atscott commented Apr 27, 2022

presubmit

Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find, thanks @atscott 👍

@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Apr 27, 2022
@dylhunn
Copy link
Contributor

dylhunn commented Apr 27, 2022

This PR was merged into the repository by commit f3eb7d9.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants