refactor(router): Remove DeprecatedLoadChildren #48292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option has already been removed from availability externally. Internally, the last use has been removed for the type on Route.loadChildren. More testing will be necessary to verify nothing relies on the other code paths.
pullapprove
bot
requested review from
AndrewKushnir,
dylhunn and
jessicajaniuk
|
Caretaker Note: Please ignore the |
atscott
added
the
merge: caretaker note
|
TGP. Waiting on 1 change to be submitted |
AndrewKushnir
approved these changes
Nov 30, 2022
AndrewKushnir
approved these changes
Nov 30, 2022
dylhunn
approved these changes
Nov 30, 2022
|
This PR was merged into the repository by commit d5aaf55. |
atscott
added a commit
that referenced
this pull request
Nov 30, 2022
This option has already been removed from availability externally. Internally, the last use has been removed for the type on Route.loadChildren. More testing will be necessary to verify nothing relies on the other code paths. PR Close #48292
sr5434
pushed a commit
to sr5434/angular
that referenced
this pull request
Dec 3, 2022
This option has already been removed from availability externally. Internally, the last use has been removed for the type on Route.loadChildren. More testing will be necessary to verify nothing relies on the other code paths. PR Close angular#48292
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
trekladyone
pushed a commit
to trekladyone/angular
that referenced
this pull request
Feb 1, 2023
This option has already been removed from availability externally. Internally, the last use has been removed for the type on Route.loadChildren. More testing will be necessary to verify nothing relies on the other code paths. PR Close angular#48292
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option has already been removed from availability externally. Internally, the last use has been removed for the type on Route.loadChildren. More testing will be necessary to verify nothing relies on the other code paths.