-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compiler-cli): resolve deprecation warning #48812
Conversation
This commit updates one usage of the `ts.factory.createMethodDeclaration` API to avoid a deprecated function signature, which avoids logging a warning.
@@ -111,7 +111,6 @@ export function generateInlineTypeCtor( | |||
|
|||
// Create the type constructor method declaration. | |||
return ts.factory.createMethodDeclaration( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know when this became deprecated? If it was in 4.8, we would have to support both signatures for a while due to g3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, it was deprecated in microsoft/TypeScript#49089 which shipped in 4.8, but the deprecation only started to report a warning in 4.9 (per this line).
The same change was recently made to a different usage of createMethodDeclaration
in #48652, so this one should also be fine in g3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR was merged into the repository by commit 4da1f29. |
This commit updates one usage of the `ts.factory.createMethodDeclaration` API to avoid a deprecated function signature, which avoids logging a warning. PR Close #48812
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`15.1.1` -> `15.1.2`](https://renovatebot.com/diffs/npm/@angular%2fanimations/15.1.1/15.1.2) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`15.1.1` -> `15.1.2`](https://renovatebot.com/diffs/npm/@angular%2fcommon/15.1.1/15.1.2) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`15.1.1` -> `15.1.2`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/15.1.1/15.1.2) | | [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | patch | [`15.1.1` -> `15.1.2`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/15.1.1/15.1.2) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`15.1.1` -> `15.1.2`](https://renovatebot.com/diffs/npm/@angular%2fcore/15.1.1/15.1.2) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`15.1.1` -> `15.1.2`](https://renovatebot.com/diffs/npm/@angular%2fforms/15.1.1/15.1.2) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`15.1.1` -> `15.1.2`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/15.1.1/15.1.2) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`15.1.1` -> `15.1.2`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/15.1.1/15.1.2) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v15.1.2`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​1512-2023-01-25) [Compare Source](angular/angular@15.1.1...15.1.2) ##### compiler | Commit | Type | Description | | -- | -- | -- | | [98ccb57117](angular/angular@98ccb57) | fix | handle css selectors with space after an escaped character. ([#​48558](angular/angular#48558)) | ##### compiler-cli | Commit | Type | Description | | -- | -- | -- | | [145f848a10](angular/angular@145f848) | fix | resolve deprecation warning ([#​48812](angular/angular#48812)) | ##### router | Commit | Type | Description | | -- | -- | -- | | [a6b10f6e59](angular/angular@a6b10f6) | fix | 'createUrlTreeFromSnapshot' with empty paths and named outlets ([#​48734](angular/angular#48734)) | #### Special Thanks Alan Agius, AleksanderBodurri, Andrew Kushnir, Andrew Scott, Charles Lyding, Dylan Hunn, JoostK, Matthieu Riegler, Paul Gschwendtner, Payam Valadkhan, Virginia Dooley, Yann Thomas LE MOIGNE and dario-piotrowicz <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTQuMSIsInVwZGF0ZWRJblZlciI6IjM0LjExNC4xIn0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1751 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
This commit updates one usage of the `ts.factory.createMethodDeclaration` API to avoid a deprecated function signature, which avoids logging a warning. PR Close angular#48812
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This commit updates one usage of the
ts.factory.createMethodDeclaration
API to avoid a deprecated function signature, which avoids logging a warning.