-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(http): allow customization of the HttpTransferCache. #52029
Conversation
9f7357d
to
b67b8dc
Compare
NIT, can you update the commit to reference #50117? |
74caec8
to
96e731e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JeanMeche the change looks good 👍
Could you please update golden files to reflect the API changes?
ebed59f
to
7b54c7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-for: public-api
7b54c7d
to
cbd7ede
Compare
FYI, I've also pushed a rebase, since the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed-for: public-api
cbd7ede
to
40ba98a
Compare
@JeanMeche it looks like there are some merge conflicts (likely after merging other PRs into the main branch). Could you please rebase when you get a chance? |
40ba98a
to
a877acb
Compare
`provideClientHydration()` accepts new `HydrationFeature` : `HttpTransferCacheOptions`. `withHttpTransferCacheOptions` accepts an option object: * `includeHeaders` : list of headers entries to keep in the cache with the request * `filter` a callback to determine if a request should be cached * `includePostRequests`: to include POST requests in the allowed methods Implements some of the features requested in angular#50117
a877acb
to
2f17947
Compare
Caretaker note: presubmit is "green", this PR is ready for merge. |
This PR was merged into the repository by commit 7dde42a. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
) `provideClientHydration()` accepts new `HydrationFeature` : `HttpTransferCacheOptions`. `withHttpTransferCacheOptions` accepts an option object: * `includeHeaders` : list of headers entries to keep in the cache with the request * `filter` a callback to determine if a request should be cached * `includePostRequests`: to include POST requests in the allowed methods Implements some of the features requested in angular#50117 PR Close angular#52029
PR previously at #51872
provideClientHydration()
accepts newHydrationFeature
:HttpTransferCacheOptions
.withHttpTransferCacheOptions
accepts an option object:includeHeaders
: list of headers entries to keep in the cache with the requestfilter
a callback to determine if a request should be cachedincludePostRequests
: to include POST requests in the allowed methodsImplements some of the features requested in #50117