fix(migrations): Add support for nested structures inside a switch statement #52358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicajaniuk
added
action: review
jessicajaniuk
requested review from
AndrewKushnir
and removed request for
alxhub
AndrewKushnir
approved these changes
Oct 24, 2023
dylhunn
approved these changes
Oct 24, 2023
crisbeto
approved these changes
Oct 24, 2023
jessicajaniuk
added
action: cleanup
…atement This updates the code to handle switches more elegantly in line with how the other blocks are handled. This allows nesting to be handled just like other blocks.
jessicajaniuk
force-pushed
the
migration-switch
branch
from
bbf7973
to
394b023
Compare
jessicajaniuk
added
action: merge
|
Caretaker note: This is safe to merge. The G3 failures are unrelated. |
|
This PR was merged into the repository by commit 9692aeb. |
georgmu
reviewed
Oct 26, 2023
| @@ -134,10 +134,12 @@ export function migrateTemplate(template: string): {migrated: string|null, error | |||
|
|
|||
| // start from top of template | |||
| // loop through each element | |||
| visitor.elements[0].hasLineBreaks = hasLineBreaks; | |||
There was a problem hiding this comment.
This crashes the migration if there are files without any control flow statements
There was a problem hiding this comment.
Thanks for the heads up. #52399 should fix this.
tbondwilkinson
pushed a commit
to tbondwilkinson/angular
that referenced
this pull request
Dec 6, 2023
…atement (angular#52358) This updates the code to handle switches more elegantly in line with how the other blocks are handled. This allows nesting to be handled just like other blocks. PR Close angular#52358
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…atement (angular#52358) This updates the code to handle switches more elegantly in line with how the other blocks are handled. This allows nesting to be handled just like other blocks. PR Close angular#52358
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the code to handle switches more elegantly in line with how the other blocks are handled. This allows nesting to be handled just like other blocks.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?