Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migrations): fix broken migration when no control flow is present #52399

Closed
wants to merge 1 commit into from

Conversation

jessicajaniuk
Copy link
Contributor

This addresses a bug that caused the control flow migration to crash when no control flow was present in the template.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No

This addresses a bug that caused the control flow migration to crash when no control flow was present in the template.
@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update` migrations target: rc This PR is targeted for the next release-candidate labels Oct 26, 2023
@ngbot ngbot bot modified the milestone: Backlog Oct 26, 2023
@jessicajaniuk jessicajaniuk added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Oct 26, 2023
@jessicajaniuk
Copy link
Contributor Author

caretaker: failing test is unrelated. this is safe to merge.

@jessicajaniuk jessicajaniuk modified the milestones: Backlog, v17-final Oct 26, 2023
@dylhunn
Copy link
Contributor

dylhunn commented Oct 26, 2023

This PR was merged into the repository by commit f1a020b.

@dylhunn dylhunn closed this in f1a020b Oct 26, 2023
dylhunn pushed a commit that referenced this pull request Oct 26, 2023
…#52399)

This addresses a bug that caused the control flow migration to crash when no control flow was present in the template.

PR Close #52399
@jessicajaniuk jessicajaniuk deleted the migration-bug branch November 9, 2023 20:34
tbondwilkinson pushed a commit to tbondwilkinson/angular that referenced this pull request Dec 6, 2023
…angular#52399)

This addresses a bug that caused the control flow migration to crash when no control flow was present in the template.

PR Close angular#52399
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 10, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
…angular#52399)

This addresses a bug that caused the control flow migration to crash when no control flow was present in the template.

PR Close angular#52399
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update` migrations merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants