fix(migrations): Switches to multiple passes to fix several reported bugs #52592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicajaniuk
added
action: review
jessicajaniuk
force-pushed
the
migrate-templates
branch
2 times, most recently
from
a1f1c51
to
77a27ab
Compare
crisbeto
approved these changes
Nov 7, 2023
packages/core/schematics/ng-generate/control-flow-migration/types.ts
Outdated
Show resolved
Hide resolved
packages/core/schematics/ng-generate/control-flow-migration/util.ts
Outdated
Show resolved
Hide resolved
packages/core/schematics/ng-generate/control-flow-migration/util.ts
Outdated
Show resolved
Hide resolved
jessicajaniuk
force-pushed
the
migrate-templates
branch
2 times, most recently
from
9f8eba6
to
4cee3cf
Compare
|
|
jessicajaniuk
added
action: merge
bulldog98
reviewed
Nov 8, 2023
packages/core/schematics/ng-generate/control-flow-migration/index.ts
Outdated
Show resolved
Hide resolved
…bugs Rather than migrate all in one pass, this now migrates in a separate pass per control flow item plus one for templates at the end. This resolves issues with multiple control flow items on a single element as well as making sure ng-templates are fully migrated before being moved to new locations. fixes: angular#52518 fixes: angular#52516 fixes: angular#52513
jessicajaniuk
force-pushed
the
migrate-templates
branch
from
4cee3cf
to
51d87f2
Compare
|
This PR was merged into the repository by commit b9e2893. |
atscott
pushed a commit
that referenced
this pull request
Nov 8, 2023
…bugs (#52592) Rather than migrate all in one pass, this now migrates in a separate pass per control flow item plus one for templates at the end. This resolves issues with multiple control flow items on a single element as well as making sure ng-templates are fully migrated before being moved to new locations. fixes: #52518 fixes: #52516 fixes: #52513 PR Close #52592
tbondwilkinson
pushed a commit
to tbondwilkinson/angular
that referenced
this pull request
Dec 6, 2023
…bugs (angular#52592) Rather than migrate all in one pass, this now migrates in a separate pass per control flow item plus one for templates at the end. This resolves issues with multiple control flow items on a single element as well as making sure ng-templates are fully migrated before being moved to new locations. fixes: angular#52518 fixes: angular#52516 fixes: angular#52513 PR Close angular#52592
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…bugs (angular#52592) Rather than migrate all in one pass, this now migrates in a separate pass per control flow item plus one for templates at the end. This resolves issues with multiple control flow items on a single element as well as making sure ng-templates are fully migrated before being moved to new locations. fixes: angular#52518 fixes: angular#52516 fixes: angular#52513 PR Close angular#52592
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than migrate all in one pass, this now migrates in a separate pass per control flow item plus one for templates at the end. This resolves issues with multiple control flow items on a single element as well as making sure ng-templates are fully migrated before being moved to new locations.
The tradeoff to supporting these cases is performance of the migration.
fixes: #52518
fixes: #52516
fixes: #52513
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?