Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-cli): interpolatedSignalNotInvoked diagnostic #53585

Closed
wants to merge 2 commits into from

Commits on Dec 15, 2023

  1. fix(compiler-cli): interpolatedSignalNotInvoked diagnostic

    The diagnostic was catching the following case:
    
    ```ts
    name = signal('Angular');
    ```
    
    but not the following ones:
    
    ```ts
    name = signal('Angular').asReadonly();
    name = computed(() => 'Angular');
    name!: Signal<string>
    ```
    
    This was not catched in the tests because the type of `Signal` is different than the one actually used in core.
    It turns out the real type forces the diagnostic to check both the `symbol.tsType.symbol` and the `symbol.tsType.aliasSymbol`.
    cexbrayat committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    e527e0f View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2023

  1. Configuration menu
    Copy the full SHA
    159b61e View commit details
    Browse the repository at this point in the history