-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: use v17 for the tutorials #55437
Conversation
Deployed adev-preview for 4485e8c to: https://ng-dev-previews-fw--pr-angular-angular-55437-adev-prev-laslt0ha.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
3439755
to
4d14855
Compare
zone.js
for the tutorials
Can you please update this Line 75 in b1dffa4
|
Partial revert of angular#54891. Webcontainers do not support node ^18.19.1 which is required by the v18 CLI. Until this is solved by the stackblitz team, we're stucked with v17 based tutorials
4d14855
to
4485e8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Why are the tutorial and Playground based on v18 at all? I would think they should be based on the current release, not the one in beta. I could see a change of confusion if the user is reading docs based on v17 and then seeing code in Tutorial or Playground that is only in v18. Or they get something working in the playground that relies on something in v18 but they don't realize that they are not using v17. |
@Chewieez Currently ADEV is build from the main branch (which currently contains v18). Infra isn't set-up yet to handle current/next releases but should be in the future. The playground currently has its own dependencies but we had a breaking change due to a renovate update that shouldn't have happened in the first place (see #54891) |
This PR was merged into the repository by commit 8dab93f. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Partial revert of #54891. Webcontainers do not support node ^18.19.1 which is required by the v18 CLI.
Until this is solved by the stackblitz team, we're stucked with v17 based tutorials
fixes #55436