Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use v17 for the tutorials #55437

Closed

Conversation

JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Apr 19, 2024

Partial revert of #54891. Webcontainers do not support node ^18.19.1 which is required by the v18 CLI.

Until this is solved by the stackblitz team, we're stucked with v17 based tutorials

fixes #55436

@angular-robot angular-robot bot added the area: docs Related to the documentation label Apr 19, 2024
@ngbot ngbot bot added this to the Backlog milestone Apr 19, 2024
Copy link

github-actions bot commented Apr 19, 2024

Deployed adev-preview for 4485e8c to: https://ng-dev-previews-fw--pr-angular-angular-55437-adev-prev-laslt0ha.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@JeanMeche JeanMeche force-pushed the docs/update-tutorials-zone-deps branch from 3439755 to 4d14855 Compare April 19, 2024 23:55
@JeanMeche JeanMeche changed the title docs: update zone.js for the tutorials docs: use v17 for the tutorials Apr 19, 2024
@JeanMeche JeanMeche marked this pull request as ready for review April 20, 2024 00:06
@alan-agius4
Copy link
Contributor

Can you please update this

"matchPaths": ["packages/**", "aio/tools/examples/shared/**"],
to include the adev patch, as otherwise as soon as this gets merged a PR will be created to re-update.

@alan-agius4 alan-agius4 self-requested a review April 22, 2024 05:24
Partial revert of angular#54891. Webcontainers do not support node ^18.19.1 which is required by the v18 CLI.

Until this is solved by the stackblitz team, we're stucked with v17 based tutorials
@JeanMeche JeanMeche force-pushed the docs/update-tutorials-zone-deps branch from 4d14855 to 4485e8c Compare April 22, 2024 12:30
@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 22, 2024
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label Apr 22, 2024
@Chewieez
Copy link

Why are the tutorial and Playground based on v18 at all? I would think they should be based on the current release, not the one in beta.

I could see a change of confusion if the user is reading docs based on v17 and then seeing code in Tutorial or Playground that is only in v18. Or they get something working in the playground that relies on something in v18 but they don't realize that they are not using v17.

@JeanMeche
Copy link
Member Author

JeanMeche commented Apr 22, 2024

@Chewieez Currently ADEV is build from the main branch (which currently contains v18). Infra isn't set-up yet to handle current/next releases but should be in the future.

The playground currently has its own dependencies but we had a breaking change due to a renovate update that shouldn't have happened in the first place (see #54891)

@alxhub alxhub removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 23, 2024
@alxhub
Copy link
Member

alxhub commented Apr 23, 2024

This PR was merged into the repository by commit 8dab93f.

@alxhub alxhub closed this in 8dab93f Apr 23, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We couldn't start the tutorial app.
6 participants