Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct browserslist behavior docs #56027

Closed
wants to merge 2 commits into from
Closed

Conversation

Char2sGu
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Wrong/Incomplete documentation, as mentioned in the following issue.

Issue Number: #56020

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

google-cla bot commented May 23, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@angular-robot angular-robot bot added the area: docs Related to the documentation label May 23, 2024
@ngbot ngbot bot added this to the Backlog milestone May 23, 2024
Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one NIT

@Char2sGu
Copy link
Contributor Author

Updated @alan-agius4

@alan-agius4
Copy link
Contributor

@Char2sGu can you please sign the CLA and also squash the commit? Thanks.

@Char2sGu
Copy link
Contributor Author

Hey @alan-agius4 I've signed the CLA, but I believe it can be more convenient to squash the commits on merge. The edits were made via GitHub Web.

Co-authored-by: Alan Agius <alan.agius4@gmail.com>
@alan-agius4
Copy link
Contributor

@Char2sGu, let me create a fixup commit message for you.

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: review The PR is still awaiting reviews from at least one requested reviewer labels May 29, 2024
@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 29, 2024
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit 400b47e.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants