fix(core): improve docs on afterRender hooks #56522
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a typo in the `AfterRenderPhase` deprecation warning and improves the documentation of the options parameter of the afterRender hooks (which are now all named `options` instead of being called `opts` in some functions and `options` in others).
AndrewKushnir
approved these changes
Jun 19, 2024
pullapprove
bot
requested review from
AndrewKushnir,
pkozlowski-opensource and
thePunderWoman
AndrewKushnir
approved these changes
Jun 19, 2024
AndrewKushnir
added
target: patch
AndrewKushnir
added
action: merge
|
Caretaker notes:
|
pkozlowski-opensource
approved these changes
Jun 20, 2024
devversion
approved these changes
Jun 20, 2024
AndrewKushnir
added
target: minor
|
This PR was merged into the repository by commit 86bcfd3. The changes were merged into the following branches: main |
|
@cexbrayat there was a merge conflict with the 18.0.x branch, so this PR was merged into the main branch only. Could you please create a new PR and target the 18.0.x branch when you get a chance? Thank you. |
13 tasks
|
@AndrewKushnir Here it is #56525 As the main part of the PR is based on changes introduced in the next release, the new PR is really small (and maybe not worth it). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The AfterPhaseRender deprecation warning has a typo.
What is the new behavior?
This commit fixes a typo in the
AfterRenderPhasedeprecation warning and improves the documentation of the options parameter of the afterRender hooks (which are now all namedoptionsinstead of being calledoptsin some functions andoptionsin others).Does this PR introduce a breaking change?
Other information