Skip to content

Conversation

cexbrayat
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the new behavior?

This commit improves the documentation of the options parameter of the afterRender hooks.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This is a rebased version of #56522 on the v18 branch as asked by @AndrewKushnir

@pullapprove pullapprove bot requested a review from alxhub June 20, 2024 16:00
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Jun 20, 2024
@ngbot ngbot bot added this to the Backlog milestone Jun 20, 2024
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cexbrayat thanks for creating a PR for the 18.0.x branch.

@AndrewKushnir AndrewKushnir removed the request for review from alxhub June 20, 2024 18:31
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 20, 2024
@AndrewKushnir
Copy link
Contributor

@cexbrayat do you mind rebasing it on top of the most recent 18.0.x branch? There were some additional commits there that fixed CI issues.

@AndrewKushnir AndrewKushnir added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Jun 20, 2024
This commit improves the documentation of the options parameter of the afterRender hooks.
@cexbrayat cexbrayat force-pushed the fix/after-render-phase-warning-typo branch from 8addf2a to 049c536 Compare June 20, 2024 20:54
@cexbrayat
Copy link
Member Author

@AndrewKushnir Sure, done!

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jun 20, 2024
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 2f73281.

The changes were merged into the following branches: 18.0.x

AndrewKushnir pushed a commit that referenced this pull request Jun 20, 2024
This commit improves the documentation of the options parameter of the afterRender hooks.

PR Close #56525
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants