Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deploy): deploying with service account #3261

Closed
wants to merge 6 commits into from

Conversation

zal1000
Copy link
Contributor

@zal1000 zal1000 commented Aug 20, 2022

Deploying with service account was not possible, becouse no checks were made for
GOOGLE_APPLICATION_CREDENTIALS env variable

Fixes #3260

Checklist

Description

Not trying to log into firebase CLI when GOOGLE_APPLICATION_CREDENTIALS are detected.
Doing that allows the deploy job to run in an automated env with a service account only

Code sample

Deploying with service account was not possible, becouse no checks were made for
GOOGLE_APPLICATION_CREDENTIALS env variable

Fixes angular#3260
@zal1000 zal1000 marked this pull request as draft August 20, 2022 20:57
Service account was not activated before deploying

Fixes angular#3260
@zal1000 zal1000 marked this pull request as ready for review August 20, 2022 21:11
@jamesdaniels
Copy link
Member

Thanks for the fix, I'll look at merging this in for a patch release ASAP

@Kunal-Deshpande
Copy link

Hi,
Do we have any update merging this MR?
Firebase is deprecating the FIREBASE_TOKEN env variable for authentication. So need to authenticate using the service account.
It would be good if the application picked up the GOOGLE_APPLICATION_CREDENTIALS env variable.

@HmFlashy
Copy link

Is there any update on this matter? thanks

@HmFlashy
Copy link

Please could someone take care of this PR? It would be really awesome thanks

@davideast davideast self-requested a review June 23, 2023 15:35
@davideast davideast self-assigned this Jun 23, 2023
Copy link
Member

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zal1000 Thank you so much and a very serious apology for the late review.

@davideast
Copy link
Member

Closing but was merged in #3396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy not working with service account in github actions
5 participants