-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deploy): deploying with service account #3261
Conversation
Deploying with service account was not possible, becouse no checks were made for GOOGLE_APPLICATION_CREDENTIALS env variable Fixes angular#3260
Service account was not activated before deploying Fixes angular#3260
Thanks for the fix, I'll look at merging this in for a patch release ASAP |
Hi, |
Is there any update on this matter? thanks |
Please could someone take care of this PR? It would be really awesome thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zal1000 Thank you so much and a very serious apology for the late review.
Closing but was merged in #3396 |
Deploying with service account was not possible, becouse no checks were made for
GOOGLE_APPLICATION_CREDENTIALS env variable
Fixes #3260
Checklist
yarn install
,yarn test
run successfully? yesDescription
Not trying to log into firebase CLI when
GOOGLE_APPLICATION_CREDENTIALS
are detected.Doing that allows the deploy job to run in an automated env with a service account only
Code sample