Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add eslint #3421

Merged
merged 2 commits into from
Aug 29, 2023
Merged

add eslint #3421

merged 2 commits into from
Aug 29, 2023

Conversation

robertIsaac
Copy link
Contributor

Checklist

  • Issue number for this PR: NA
  • Docs included?: no
  • Test units included?: no
  • In a clean directory, yarn install, yarn test run successfully? no

Description

adding initial eslint and fixing the current errors

@robertIsaac robertIsaac force-pushed the add-eslint branch 2 times, most recently from 73e57ad to 4e28c06 Compare August 29, 2023 09:35
Copy link
Member

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertIsaac I can not thank you enough for this!

@davideast davideast merged commit 4172abd into angular:master Aug 29, 2023
18 checks passed
@robertIsaac
Copy link
Contributor Author

@robertIsaac I can not thank you enough for this!

I'm really happy to see it merged :)

@robertIsaac
Copy link
Contributor Author

@davideast I can also add prettier and eslint prettier plugin, if that's something you'd like to have in the project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants