This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review #51 first.
This is a POC of a RenderService (angular/angular#2409). It uses monkey patching to serialize arguments to RenderService functions at runtime and run the function on the render thread and pass the result (if any) back to the app thread automatically. There are a few issues with this implementation that will need to be addressed for any RenderService implementation that makes its way into angular:
ngOnDestroy
hook gets fired so the argument can't be serialized.ngStartListening
(an example of this is inmain_ui
of this PR. There should probably be a more straightforward API for this.Once we create a RenderService implementation that addresses all of these issues we can use it to replace the WebWorker Renderer implementation and the angularfire auth implementation.