Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stepper [completed]="true" cannot skip steps #15310

Closed
skyfremen opened this issue Feb 26, 2019 · 1 comment · Fixed by #15403
Closed

Stepper [completed]="true" cannot skip steps #15310

skyfremen opened this issue Feb 26, 2019 · 1 comment · Fixed by #15403
Assignees
@crisbeto
Labels
P4 A relatively minor issue that is not relevant to core functions

Comments

@skyfremen
Copy link

skyfremen commented Feb 26, 2019 •
edited
Loading

What is the expected behavior?

Linear stepper - Able to Move from Step 1 to Step 3 when [completed]="true" is set

What is the current behavior?

Linear stepper -
Need to touch step 2 to be able to move from Step 1 to Step 3 when [completed]="true" is set

What are the steps to reproduce?

https://stackblitz.com/edit/angular-bmwaq7
[completed]="true" is set on all steps.

  1. Click on Step 3 (Not able to move from Step1 to Step3) << Possible Bug
  2. Click on Step 2 (Able to move from Step1 to Step2)
  3. Click on Step 1 (Able to move to Step 2 to Step 1)
  4. Click on Step 3 (Able to move from Step1 to Step3)

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular 7.2.6
Material 7.3.1

Is there anything else we should know?
@crisbeto crisbeto self-assigned this Mar 6, 2019
@crisbeto crisbeto added has pr P4 A relatively minor issue that is not relevant to core functions labels Mar 6, 2019
crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 6, 2019
@crisbeto
fix(stepper): unable to skip step if completed value is overwritten
1ece8b1 
Currently we allow for the `completed` value of a step to be overwritten, however setting it to `true` still won't allow the user to skip the step, because the `interacted` flag won't be flipped if they haven't been on a particular step before.

Fixes angular#15310.
@crisbeto crisbeto mentioned this issue Mar 6, 2019
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 6, 2019
@crisbeto
fix(stepper): unable to skip step if completed value is overwritten
943ecf7 
Currently we allow for the `completed` value of a step to be overwritten, however setting it to `true` still won't allow the user to skip the step, because the `interacted` flag won't be flipped if they haven't been on a particular step before.

Fixes angular#15310.
crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 13, 2019
@crisbeto
fix(stepper): unable to skip step if completed value is overwritten
96f83ab 
Currently we allow for the `completed` value of a step to be overwritten, however setting it to `true` still won't allow the user to skip the step, because the `interacted` flag won't be flipped if they haven't been on a particular step before.

Fixes angular#15310.
crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 13, 2019
@crisbeto
fix(stepper): unable to skip step if completed value is overwritten
ff7225c 
Currently we allow for the `completed` value of a step to be overwritten, however setting it to `true` still won't allow the user to skip the step, because the `interacted` flag won't be flipped if they haven't been on a particular step before.

Fixes angular#15310.
crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 18, 2019
@crisbeto
fix(stepper): unable to skip step if completed value is overwritten
ffe1765 
Currently we allow for the `completed` value of a step to be overwritten, however setting it to `true` still won't allow the user to skip the step, because the `interacted` flag won't be flipped if they haven't been on a particular step before.

Fixes angular#15310.
@FritzHerbers FritzHerbers mentioned this issue Mar 27, 2019
Closed
crisbeto added a commit to crisbeto/material2 that referenced this issue Jun 15, 2019
@crisbeto
fix(stepper): unable to skip step if completed value is overwritten
0e64c4b 
Currently we allow for the `completed` value of a step to be overwritten, however setting it to `true` still won't allow the user to skip the step, because the `interacted` flag won't be flipped if they haven't been on a particular step before.

Fixes angular#15310.
jelbourn pushed a commit that referenced this issue Sep 6, 2019
@crisbeto @jelbourn
fix(stepper): unable to skip step if completed value is overwritten
c98af9d 
Currently we allow for the `completed` value of a step to be overwritten, however setting it to `true` still won't allow the user to skip the step, because the `interacted` flag won't be flipped if they haven't been on a particular step before.

Fixes #15310.
mmalerba pushed a commit that referenced this issue Oct 2, 2019
@crisbeto @mmalerba
fix(stepper): unable to skip step if completed value is overwritten (#…
bebb9ff 
…15403)

Currently we allow for the `completed` value of a step to be overwritten, however setting it to `true` still won't allow the user to skip the step, because the `interacted` flag won't be flipped if they haven't been on a particular step before.

Fixes #15310.
mmalerba pushed a commit that referenced this issue Oct 8, 2019
@crisbeto @mmalerba
fix(stepper): unable to skip step if completed value is overwritten (#…
9f497a0 
…15403)

Currently we allow for the `completed` value of a step to be overwritten, however setting it to `true` still won't allow the user to skip the step, because the `interacted` flag won't be flipped if they haven't been on a particular step before.

Fixes #15310.

(cherry picked from commit bebb9ff)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(stepper): unable to skip step if completed value is overwritten crisbeto/material2
2 participants
@crisbeto @skyfremen