Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ng add @angular/bazel fails due to CDK #16189

Closed
jonr-elsewhen opened this issue Jun 3, 2019 · 5 comments
Closed

ng add @angular/bazel fails due to CDK #16189

jonr-elsewhen opened this issue Jun 3, 2019 · 5 comments
Assignees
@jelbourn @devversion
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@jonr-elsewhen
Copy link

Reproduction

Steps to reproduce:

  1. ng new cdk-and-bazel-are-broken
  2. cd cdk-and-bazel-are-broken
  3. npm i @angular/cdk --save
  4. ng add @angular/bazel

Expected Behavior

It should work.

Actual Behavior

> ngc -p ./angular-metadata.tsconfig.json

node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.spec.ts(4,10): error TS1003: Identifier expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.spec.ts(4,11): error TS1110: Type expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.spec.ts(4,30): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.spec.ts(4,41): error TS1128: Declaration or statement expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.spec.ts(4,48): error TS1005: ';' expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.spec.ts(7,19): error TS1139: Type parameter declaration expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.spec.ts(7,30): error TS1005: '>' expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.spec.ts(7,37): error TS1005: '=>' expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.spec.ts(7,38): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.spec.ts(8,34): error TS1139: Type parameter declaration expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.spec.ts(8,45): error TS1005: ',' expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.spec.ts(8,53): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.spec.ts(8,64): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.spec.ts(12,24): error TS1110: Type expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.spec.ts(12,43): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.spec.ts(21,40): error TS1110: Type expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.spec.ts(21,59): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(1,19): error TS1005: ',' expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(1,20): error TS1110: Type expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(1,22): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(1,48): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(1,49): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(1,50): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(1,70): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(1,72): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(1,73): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(1,74): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(1,76): error TS1110: Type expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(1,78): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(1,114): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(1,115): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(1,116): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(1,142): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(1,144): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(1,145): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(1,146): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(1,148): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(1,155): error TS1005: ';' expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(5,31): error TS1136: Property assignment expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(5,32): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(5,33): error TS1146: Declaration expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(5,34): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(5,55): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(5,56): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(6,11): error TS1005: ';' expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(8,6): error TS1110: Type expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(8,8): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(8,17): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(8,18): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(9,14): error TS1005: ';' expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(9,59): error TS1110: Type expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(9,61): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(9,81): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(9,82): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(10,9): error TS1005: ';' expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(12,7): error TS1110: Type expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(12,9): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(12,18): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(12,19): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(13,12): error TS1005: ';' expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(13,67): error TS1110: Type expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(13,69): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(13,71): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(13,72): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(13,74): error TS1110: Type expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(13,76): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(13,102): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(13,103): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(14,16): error TS1005: ';' expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(14,36): error TS1003: Identifier expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(14,37): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(14,59): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(14,60): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(14,62): error TS1110: Type expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(14,64): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(14,103): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(14,104): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(15,18): error TS1005: ';' expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(15,44): error TS1003: Identifier expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(15,45): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(15,65): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(15,66): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(15,68): error TS1110: Type expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(15,70): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(15,72): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(15,73): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(16,1): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(16,2): error TS1128: Declaration or statement expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(17,15): error TS1139: Type parameter declaration expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(17,26): error TS1005: '>' expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(17,34): error TS1109: Expression expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(17,45): error TS1005: ';' expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(33,13): error TS1005: ',' expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(33,36): error TS1005: '(' expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(33,38): error TS1005: ',' expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(34,14): error TS1005: ',' expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(34,52): error TS1005: ',' expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(34,54): error TS1005: ';' expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(36,7): error TS1128: Declaration or statement expected.
node_modules/@angular/cdk/schematics/ng-generate/drag-drop/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts(43,1): error TS1128: Declaration or statement expected.

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! cdk-and-bazel-are-broken@0.0.0 postinstall: `ngc -p ./angular-metadata.tsconfig.json`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the cdk-and-bazel-are-broken@0.0.0 postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

Environment

  • Angular: 8
  • CDK/Material: 8
  • Browser(s): N/A
  • Operating System (e.g. Windows, macOS, Ubuntu): macOS
@alexeagle
Copy link
Contributor

We run ngc on the packages in node_modules as a post-install step. Sadly ngc itself doesn't know to skip these files.
You'll have to add an excludes to the angular-metadata.tsconfig.json to skip these files.
Note that with Ivy, we no longer need to run ngc on the node_modules since Ivy includes a different compatibility compiler ngcc, and that doesn't suffer from this problem.

jelbourn added a commit to angular/angular that referenced this issue Jun 3, 2019
@jelbourn
fix(bazel): exclude components schematics from build
6a74978 
See angular/components#16189

Without this, bazel attempts to build schematics templates as srcs
@jelbourn jelbourn mentioned this issue Jun 3, 2019
Closed
@jelbourn jelbourn self-assigned this Jun 3, 2019
@jelbourn
Copy link
Member

jelbourn commented Jun 3, 2019

I sent angular/angular#30825 to add our schematics to the default list of excludes

@devversion
Copy link
Member

Long-term we should change to the .template suffix so that these files using template syntax are not treated as valid TypeScript files.

@devversion devversion self-assigned this Jun 4, 2019
@josephperrott josephperrott added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Jun 4, 2019
devversion added a commit to devversion/material2 that referenced this issue Jun 5, 2019
@devversion
refactor(ng-generate): use .template suffix for schematic template files
d2c65ab 
Switches all schematic template files to the `.template` file extension. This
ensures that these files are not accidentally picked up in external
projects (e.g. when building the summary files with ngc).

Related to angular#16189
@devversion devversion mentioned this issue Jun 5, 2019
Merged
devversion added a commit to devversion/material2 that referenced this issue Jun 5, 2019
@devversion
refactor(ng-generate): use .template suffix for schematic template files
067dd19 
Switches all schematic template files to the `.template` file extension. This
ensures that these files are not accidentally picked up in external
projects (e.g. when building the summary files with ngc).

Related to angular#16189
jelbourn added a commit to angular/angular that referenced this issue Jun 5, 2019
@jelbourn
fix(bazel): exclude components schematics from build
95ad7f1 
See angular/components#16189

Without this, bazel attempts to build schematics templates as srcs
devversion added a commit to devversion/material2 that referenced this issue Jun 5, 2019
@devversion
refactor(ng-generate): use .template suffix for schematic template files
6306e24 
Switches all schematic template files to the `.template` file extension. This
ensures that these files are not accidentally picked up in external
projects (e.g. when building the summary files with ngc).

Related to angular#16189
mhevery pushed a commit to angular/angular that referenced this issue Jun 6, 2019
@jelbourn @mhevery
fix(bazel): exclude components schematics from build (#30825)
05a43ca 
See angular/components#16189

Without this, bazel attempts to build schematics templates as srcs

PR Close #30825
devversion added a commit to devversion/material2 that referenced this issue Jun 6, 2019
@devversion
refactor(ng-generate): use .template suffix for schematic template files
4f8ed7b 
Switches all schematic template files to the `.template` file extension. This
ensures that these files are not accidentally picked up in external
projects (e.g. when building the summary files with ngc).

Related to angular#16189
@devversion
Copy link
Member

Closing as this has been fixed upstream with angular/angular#30825. Additionally #16213 would also fix this as it ensures that there are no invalid .ts files in the NPM package.

devversion added a commit to devversion/material2 that referenced this issue Jun 6, 2019
@devversion
refactor(ng-generate): use .template suffix for schematic template files
698025f 
Switches all schematic template files to the `.template` file extension. This
ensures that these files are not accidentally picked up in external
projects (e.g. when building the summary files with ngc).

Related to angular#16189
josephperrott pushed a commit that referenced this issue Jun 7, 2019
@devversion @josephperrott
refactor(ng-generate): use .template suffix for schematic template fi…
f6903da 
…les (#16213)

Switches all schematic template files to the `.template` file extension. This
ensures that these files are not accidentally picked up in external
projects (e.g. when building the summary files with ngc).

Related to #16189
josephperrott pushed a commit that referenced this issue Jun 10, 2019
@devversion @josephperrott
refactor(ng-generate): use .template suffix for schematic template fi…
8e872e8 
…les (#16213)

Switches all schematic template files to the `.template` file extension. This
ensures that these files are not accidentally picked up in external
projects (e.g. when building the summary files with ngc).

Related to #16189
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this issue Jun 21, 2019
@devversion @RudolfFrederiksen
refactor(ng-generate): use .template suffix for schematic template fi…
c096d77 
…les (angular#16213)

Switches all schematic template files to the `.template` file extension. This
ensures that these files are not accidentally picked up in external
projects (e.g. when building the summary files with ngc).

Related to angular#16189
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jelbourn jelbourn

@devversion devversion

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@alexeagle @jelbourn @devversion @josephperrott @jonr-elsewhen