Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(AngularMaterial/BUTTON): Correct HTML Syntax #20392

Closed
forsti0506 opened this issue Aug 22, 2020 · 2 comments
Closed

bug(AngularMaterial/BUTTON): Correct HTML Syntax #20392

forsti0506 opened this issue Aug 22, 2020 · 2 comments

Comments

@forsti0506
Copy link
Contributor

Reproduction

Steps to reproduce:

  1. Go to HTML-Code of Material Button: https://github.com/angular/components/blob/master/src/material/button/button.html
  2. There you see the syntax of a material Button which leads to div tags inside a button tag which is not a valid html structure.

Fix

Replace the 2 divs with a span for valid html
<span class="mat-button-wrapper"><ng-content></ng-content></span> <span matRipple class="mat-button-ripple" [class.mat-button-ripple-round]="isRoundButton || isIconButton" [matRippleDisabled]="_isRippleDisabled()" [matRippleCentered]="isIconButton" [matRippleTrigger]="_getHostElement()"></span> <span class="mat-button-focus-overlay"></span>

@forsti0506 forsti0506 added the needs triage This issue needs to be triaged by the team label Aug 22, 2020
@crisbeto
Copy link
Member

There are a couple of in-progress PRs that will resolve this: #20376 and #20390.

@crisbeto crisbeto added area: material/button and removed needs triage This issue needs to be triaged by the team labels Aug 23, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants