Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(button-toggle): don't use divs inside button template #20390

Merged
merged 1 commit into from
Sep 16, 2020
Merged

fix(button-toggle): don't use divs inside button template #20390

merged 1 commit into from
Sep 16, 2020

Conversation

crisbeto
Copy link
Member

Along the same lines as #20376. Doesn't use divs inside the button toggle.

@crisbeto
fix(button-toggle): don't use divs inside button template
b56f27e 
Along the same lines as angular#20376. Doesn't use divs inside the button toggle.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Aug 22, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 22, 2020
@crisbeto crisbeto mentioned this pull request Aug 23, 2020
Closed
mmalerba
mmalerba approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though like with the button one there are likely to be some broken tests in g3 that will need to be updated before this can go in

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Aug 24, 2020
@wagnermaciel wagnermaciel merged commit 85e8f34 into angular:master Sep 16, 2020
wagnermaciel pushed a commit that referenced this pull request Sep 16, 2020
@crisbeto @wagnermaciel
fix(button-toggle): don't use divs inside button template (#20390)
95e48bb 
Along the same lines as #20376. Doesn't use divs inside the button toggle.

(cherry picked from commit 85e8f34)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @mmalerba @googlebot @wagnermaciel