Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(MAT-SELECT): Arrow not centered on density smaller than -1 #26757

Closed
1 task
Gunyon opened this issue Mar 9, 2023 · 1 comment · Fixed by #27011
Closed
1 task

bug(MAT-SELECT): Arrow not centered on density smaller than -1 #26757

Gunyon opened this issue Mar 9, 2023 · 1 comment · Fixed by #27011
Assignees
@crisbeto
Labels
area: material/select P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@Gunyon
Copy link

Gunyon commented Mar 9, 2023

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

mat-select with appearance="fill" the arrow is not positioned correctly on density -2 and -3 probably because label is not shown for these densities

https://stackblitz.com/edit/angular-vhd2sd?file=src%2Fmain.ts,src%2Fglobal_styles.scss

Reproduction

Steps to reproduce:

  1. Open stackblitz
  2. Change density to -2 or -3

Expected Behavior

Arrow should be centered

Actual Behavior

Arrow is above center

Environment

  • Angular: "@angular/core": "^15.1.2"
  • CDK/Material: "@angular/cdk": "15.2.2"
  • Browser(s): Version 110.0.5481.177 (Official Build) (64-bit)
  • Operating System (e.g. Windows, macOS, Ubuntu): Ubuntu 22.04.2 LTS
@Gunyon Gunyon added the needs triage This issue needs to be triaged by the team label Mar 9, 2023
@crisbeto crisbeto self-assigned this Apr 29, 2023
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent area: material/select and removed needs triage This issue needs to be triaged by the team labels Apr 29, 2023
crisbeto added a commit to crisbeto/material2 that referenced this issue Apr 29, 2023
@crisbeto
fix(material/select): ensure arrow is centered on all densities
2d4da1c 
On lower densities some form field appearances hide the label which caused the arrow to be misaligned. These changes switch the arrow to absolute position which should be more robust.

Fixes angular#26757.
crisbeto added a commit to crisbeto/material2 that referenced this issue Apr 29, 2023
@crisbeto
fix(material/select): ensure arrow is centered on all densities
440d2f5 
On lower densities some form field appearances hide the label which caused the arrow to be misaligned. These changes switch the arrow to absolute position which should be more robust.

Fixes angular#26757.
@crisbeto crisbeto mentioned this issue May 1, 2023
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue May 2, 2023
@crisbeto
fix(material/select): ensure arrow is centered on all densities
b16cef1 
On lower densities some form field appearances hide the label which caused the arrow to be misaligned. These changes add an override to center the label again.

Fixes angular#26757.
crisbeto added a commit to crisbeto/material2 that referenced this issue May 2, 2023
@crisbeto
fix(material/select): ensure arrow is centered on all densities
4ba1d04 
On lower densities some form field appearances hide the label which caused the arrow to be misaligned. These changes add an override to center the label again.

Fixes angular#26757.
crisbeto added a commit to crisbeto/material2 that referenced this issue May 2, 2023
@crisbeto
fix(material/select): ensure arrow is centered on all densities
12bd465 
On lower densities some form field appearances hide the label which caused the arrow to be misaligned. These changes add an override to center the label again.

Fixes angular#26757.
crisbeto added a commit to crisbeto/material2 that referenced this issue May 2, 2023
@crisbeto
fix(material/select): ensure arrow is centered on all densities
1cdd781 
On lower densities some form field appearances hide the label which caused the arrow to be misaligned. These changes add an override to center the label again.

Fixes angular#26757.
angular-robot bot pushed a commit that referenced this issue May 4, 2023
@crisbeto
fix(material/select): ensure arrow is centered on all densities (#27011)
d0cd9bb 
On lower densities some form field appearances hide the label which caused the arrow to be misaligned. These changes add an override to center the label again.

Fixes #26757.
angular-robot bot pushed a commit that referenced this issue May 4, 2023
@crisbeto
fix(material/select): ensure arrow is centered on all densities (#27011)
d018bf6 
On lower densities some form field appearances hide the label which caused the arrow to be misaligned. These changes add an override to center the label again.

Fixes #26757.

(cherry picked from commit d0cd9bb)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
area: material/select P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(material/select): ensure arrow is centered on all densities crisbeto/material2
2 participants
@crisbeto @Gunyon