Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/select): ensure arrow is centered on all densities #27011

Merged
merged 1 commit into from May 4, 2023

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 1, 2023

On lower densities some form field appearances hide the label which caused the arrow to be misaligned. These changes add an override to center the label again.

Fixes #26757.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels May 1, 2023
@crisbeto crisbeto force-pushed the 26757/select-arrow-centering branch from 440d2f5 to b16cef1 Compare May 2, 2023 11:09
@crisbeto crisbeto requested a review from andrewseguin May 2, 2023 11:13
@crisbeto crisbeto force-pushed the 26757/select-arrow-centering branch 2 times, most recently from 4ba1d04 to 12bd465 Compare May 2, 2023 15:16
On lower densities some form field appearances hide the label which caused the arrow to be misaligned. These changes add an override to center the label again.

Fixes angular#26757.
@crisbeto crisbeto force-pushed the 26757/select-arrow-centering branch from 12bd465 to 1cdd781 Compare May 2, 2023 15:24
@crisbeto crisbeto self-assigned this May 2, 2023
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 2, 2023
@angular-robot angular-robot bot merged commit d0cd9bb into angular:main May 4, 2023
22 of 24 checks passed
angular-robot bot pushed a commit that referenced this pull request May 4, 2023
On lower densities some form field appearances hide the label which caused the arrow to be misaligned. These changes add an override to center the label again.

Fixes #26757.

(cherry picked from commit d0cd9bb)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(MAT-SELECT): Arrow not centered on density smaller than -1
2 participants