Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(form-field): Prefix and suffix text color mismatched from spec #27628

Open
1 task
amysorto opened this issue Aug 11, 2023 · 2 comments
Open
1 task

bug(form-field): Prefix and suffix text color mismatched from spec #27628

amysorto opened this issue Aug 11, 2023 · 2 comments
Assignees
@zarend
Labels
area: material/form-field P4 A relatively minor issue that is not relevant to core functions

Comments

@amysorto
Copy link
Contributor

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

Currently the text appears black instead of the gray color in the spec.

Reproduction

Spec: https://m2.material.io/components/text-fields
Prefix and suffix demo: https://material.angular.io/components/form-field/examples#form-field-prefix-suffix.

Expected Behavior

Text is gray

Actual Behavior

Text is black

Environment

  • Angular:
  • CDK/Material:
  • Browser(s):
  • Operating System (e.g. Windows, macOS, Ubuntu):
@amysorto amysorto added P4 A relatively minor issue that is not relevant to core functions area: material/form-field labels Aug 11, 2023
@zarend
Copy link
Contributor

zarend commented Aug 15, 2023

Hello,

According to my understanding of the gm2 spec the color of the prefix text, suffix text, leading icon and trailing icon matches the placeholder color. I believe the gray color referenced in the issue report is the placeholder color.

Best regards,

Zach

@zarend zarend self-assigned this Aug 15, 2023
zarend added a commit to zarend/components that referenced this issue Aug 15, 2023
@zarend
fix(material/form-field): correct color of prefix/suffix text
0d3353b 
Correct the color of the prefix and suffix text in form fields to align
with MD spec. Set the color of the prefix and suffix text to the same
color as the placeholder. Do this by adding support to form-field for
the input-text-prefix-color and input-text-suffix-color tokens. Then,
set the values of the tokens to the same value as the prefix.

Fix angular#27628
@zarend zarend mentioned this issue Aug 15, 2023
Closed
@zarend
Copy link
Contributor

zarend commented Aug 22, 2023

Hello folks,

I'm currently traveling in the Bay Area from August 14 to August 25, and may be slow to reply.

This is a P4 issue, and I have a fix in progress for it. #27658 fixes this issue can causes in the 10's of targets to break internally, will need some work to land internally. I can likely finish this in September.

Note that I am frequently traveling this quarter, so response times on specific issues may be delayed.

Best regards,

Zach

zarend added a commit to zarend/components that referenced this issue Oct 2, 2023
@zarend
fix(material/form-field): correct color of prefix/suffix text
a1a51ff 
Correct the color of the prefix and suffix text in form fields to align
with MD spec. Set the color of the prefix and suffix text to the same
color as the placeholder. Do this by adding support to form-field for
the input-text-prefix-color and input-text-suffix-color tokens. Then,
set the values of the tokens to the same value as the prefix.

Fix angular#27628
zarend added a commit to zarend/components that referenced this issue Jan 22, 2024
@zarend
fix(material/form-field): correct color of prefix/suffix text
0050b87 
Correct the color of the prefix and suffix text in form fields to align
with MD spec. Set the color of the prefix and suffix text to the same
color as the placeholder. Do this by adding support to form-field for
the input-text-prefix-color and input-text-suffix-color tokens. Then,
set the values of the tokens to the same value as the prefix.

Fix angular#27628
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zarend zarend

Labels
area: material/form-field P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(material/form-field): correct color of prefix/suffix text zarend/components
2 participants
@zarend @amysorto