refactor(table): rename MatTableDataSource to ClientArrayTableDataSource #15432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
andrewseguin,
devversion and
jelbourn
as code owners
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
14378/table-data-source-rename
branch
3 times, most recently
from
ac4664a
to
705ec29
Compare
jelbourn
previously approved these changes
Mar 11, 2019
There was a problem hiding this comment.
LGTM
@andrewseguin should also approve this before it goes in (since he might disagree)
Renames the `MatTableDataSource` to `ClientArrayTableDataSource` to make it a bit clearer what it's supposed to be used for. Fixes angular#14378.
crisbeto
force-pushed
the
14378/table-data-source-rename
branch
from
705ec29
to
1deb759
Compare
This was referenced May 13, 2019
andrewseguin
added
the
P3
andrewseguin
approved these changes
Jun 15, 2020
andrewseguin
added
P4
|
Added to 11.0.0 milestone |
jelbourn
added
P3
|
Needs rebase |
andrewseguin
removed
the
cla: yes
andrewseguin
removed
the
P3
josephperrott
added
action: cleanup
|
I'm closing this since it's pretty breaking and way out of date. We can recreate it if we still think it's a good idea. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames the
MatTableDataSourcetoClientArrayTableDataSourceto make it a bit clearer what it's supposed to be used for.Fixes #14378.