Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename MatTableDataSource to ClientArrayTableDataSource #14378

Open
jelbourn opened this issue Dec 4, 2018 · 0 comments
Open

Rename MatTableDataSource to ClientArrayTableDataSource #14378

jelbourn opened this issue Dec 4, 2018 · 0 comments
Labels
area: material/table feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@jelbourn
Copy link
Member

jelbourn commented Dec 4, 2018

I see too frequently people misunderstand the intent behind MatTableDataSource, thinking that it's meant to be the primary (or only) way to add data to the table. Renaming this, and more eminently presenting it in the docs as just one option would hopefully help clear this up.

Obviously this will need to be done in a backwards compatible way. It will also need a migration schematic.

@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Dec 4, 2018
@andrewseguin andrewseguin added the feature This issue represents a new feature or feature request rather than a bug or bug fix label Dec 10, 2018
@crisbeto crisbeto self-assigned this Mar 10, 2019
crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 10, 2019
Renames the `MatTableDataSource` to `ClientArrayTableDataSource` to make it a bit clearer what it's supposed to be used for.

Fixes angular#14378.
crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 10, 2019
Renames the `MatTableDataSource` to `ClientArrayTableDataSource` to make it a bit clearer what it's supposed to be used for.

Fixes angular#14378.
crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 10, 2019
Renames the `MatTableDataSource` to `ClientArrayTableDataSource` to make it a bit clearer what it's supposed to be used for.

Fixes angular#14378.
crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 16, 2019
Renames the `MatTableDataSource` to `ClientArrayTableDataSource` to make it a bit clearer what it's supposed to be used for.

Fixes angular#14378.
@mmalerba mmalerba removed the has pr label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: material/table feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants