Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes touched status not needing a CD Cycle #15992

Closed
wants to merge 2 commits into from

Conversation

VamsiDharmaji
Copy link

Radio Group CVA doesnt reflect Touched status on ngControl with OnPush on the parent component using MatRadio Group. Needs one more CD cycle to reflect. This change will fix it

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 10, 2019
@VamsiDharmaji
Copy link
Author

Can anyone guide me how to get this PR move forward? @crisbeto Let me know if I missed anything or not followed the process

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay @VamsiDharmaji, I think it just got lost in between all the other PRs. The change looks reasonable, but would you be able to add a unit test for it?

@VamsiDharmaji
Copy link
Author

Sorry for the delay @VamsiDharmaji, I think it just got lost in between all the other PRs. The change looks reasonable, but would you be able to add a unit test for it?

Will do, thanks for the prompt response. Will update it here

@andrewseguin andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2021
@andrewseguin
Copy link
Contributor

Closing due to inactivity from the author (tests requested). If you'd like to continue to land this change, please feel free to reopen a rebased version with tests

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants