Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: switch acceptance members to type aliases #17653

Merged
merged 3 commits into from Dec 16, 2019
Merged

refactor: switch acceptance members to type aliases #17653

merged 3 commits into from Dec 16, 2019

Commits on Dec 13, 2019

  1. refactor: switch acceptance members to type aliases 

    Instead of manually typing the union types for boolean
and number inputs, we should use a type alias.

This allows us to make changes easier in the future, and
it avoids a lot of repetition.
    @devversion @mmalerba
    devversion authored and mmalerba committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    8c386e6 View commit details
    Browse the repository at this point in the history

  2. fixup! refactor: switch acceptance members to type aliases 

    Update goldens
    @devversion @mmalerba
    devversion authored and mmalerba committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    552d397 View commit details
    Browse the repository at this point in the history

  3. fix rebase issue

    @mmalerba
    mmalerba committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    1e395ed View commit details
    Browse the repository at this point in the history