Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: switch acceptance members to type aliases #17653

Open

Conversation

@devversion
Copy link
Member

devversion commented Nov 8, 2019

Follow-up PR to #17640. It has been told to me that #17640 already has a presubmit, so I submitted the type alias change as a separate PR. Happy to merge that into a single PR if we can easily get the new PR merged too.

@devversion devversion requested review from andrewseguin, crisbeto, jelbourn, mmalerba and angular/dev-infra-components as code owners Nov 8, 2019
@googlebot googlebot added the cla: yes label Nov 8, 2019
Copy link
Member

jelbourn left a comment

LGTM

@jelbourn jelbourn added the pr: lgtm label Nov 8, 2019
Copy link
Member

crisbeto left a comment

LGTM

devversion added 2 commits Nov 8, 2019
Instead of manually typing the union types for boolean
and number inputs, we should use a type alias.

This allows us to make changes easier in the future, and
it avoids a lot of repetition.
Update goldens
@devversion devversion force-pushed the devversion:follow-up-coercion-inputs-acceptance-members branch from 3f4efd8 to f1e70d5 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.