Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sidenav): unable to close by pressing escape in side mode #17967

Closed
wants to merge 1 commit into from
Closed

fix(sidenav): unable to close by pressing escape in side mode #17967

wants to merge 1 commit into from

Commits on Dec 14, 2019

  1. fix(sidenav): unable to close by pressing escape in side mode 

    We currently listen for `keydown` events on the sidenav so that we know when to close it, however in `side` mode we don't trap focus inside the sidenav which means that unless the user goes into the sidenav manually, the escape listener won't work. These changes fix the issue by listening to keyboard events at the `document` level.

Fixes angular#17965.
    @crisbeto
    crisbeto committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    9ecf504 View commit details
    Browse the repository at this point in the history