Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-chips): don't allow focus on checkmark icon #18588

Merged
merged 1 commit into from
Feb 26, 2020
Merged

fix(material-experimental/mdc-chips): don't allow focus on checkmark icon #18588

merged 1 commit into from
Feb 26, 2020

Conversation

crisbeto
Copy link
Member

On some browsers SVG elements default to being focusable, which means that currently users are able to tab into the checkmark icon of the MDC chip option. These changes make it so that the element isn't focusable.

@crisbeto
fix(material-experimental/mdc-chips): don't allow focus on checkmark …
0d54a65 
…icon

On some browsers SVG elements default to being focusable, which means that currently users are able to tab into the checkmark icon of the MDC chip option. These changes make it so that the element isn't focusable.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Feb 23, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 23, 2020
mmalerba
mmalerba approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 25, 2020
@mmalerba
Copy link
Contributor

should we have a lint to check svg elements for this property?

@crisbeto
Copy link
Member Author

Setting up linting for HTML would be a bigger effort since we don't have something for it in place already.

@jelbourn jelbourn mentioned this pull request Feb 26, 2020
Open
@jelbourn
Copy link
Member

Filed angular/dev-infra#74

@jelbourn jelbourn merged commit 1c2300f into angular:master Feb 26, 2020
jelbourn pushed a commit that referenced this pull request Mar 3, 2020
@crisbeto @jelbourn
fix(material-experimental/mdc-chips): don't allow focus on checkmark …
8637f66 
…icon (#18588)

On some browsers SVG elements default to being focusable, which means that currently users are able to tab into the checkmark icon of the MDC chip option. These changes make it so that the element isn't focusable.

(cherry picked from commit 1c2300f)
This was referenced Mar 11, 2020
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 27, 2020
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 28, 2020
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @mmalerba @jelbourn @googlebot