Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(datepicker): fix various missing words #20244

Merged
merged 1 commit into from
Aug 12, 2020
Merged

docs(datepicker): fix various missing words #20244

merged 1 commit into from
Aug 12, 2020

Conversation

ccjmne
Copy link
Contributor

@ccjmne ccjmne commented Aug 7, 2020

Changes:

- They work in
+ They work in tandem,
  similarly to the `mat-datepicker` and the basic datepicker input.
  The `mat-date-range-picker` component acts
- the the
+ as the
  pop-up panel for selecting dates.

@ccjmne ccjmne requested a review from mmalerba as a code owner August 7, 2020 22:13
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 7, 2020
mmalerba
mmalerba approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker merge safe labels Aug 7, 2020
@andrewseguin andrewseguin added the target: patch This PR is targeted for the next patch release label Aug 12, 2020
@andrewseguin andrewseguin merged commit 8050e7e into angular:master Aug 12, 2020
andrewseguin pushed a commit that referenced this pull request Aug 12, 2020
@ccjmne @andrewseguin
Fix extraneous & missing words in datepicker docs (#20244)
095069b 
(cherry picked from commit 8050e7e)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ccjmne @mmalerba @googlebot @andrewseguin